Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add usage reports for js-lite (web) sdk #26324

Merged
merged 11 commits into from
Nov 26, 2024

Conversation

marandaneto
Copy link
Member

Problem

inspired by https://posthog.slack.com/archives/C03P7NL6RMW/p1732131344932259?thread_ts=1732130847.109069&cid=C03P7NL6RMW

Changes

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

How did you test this code?

@marandaneto marandaneto requested review from a team November 21, 2024 07:51
@marandaneto
Copy link
Member Author

marandaneto commented Nov 25, 2024

@PostHog/team-growth or @PostHog/team-replay I'd love some eyes on this, thx

Copy link
Member

@pauldambra pauldambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks right... i don't know how i'd test it 🙈

@marandaneto marandaneto merged commit a903900 into master Nov 26, 2024
89 checks passed
@marandaneto marandaneto deleted the chore/js-lite-usage-reports branch November 26, 2024 07:43
@marandaneto
Copy link
Member Author

looks right... i don't know how i'd test it 🙈

I will tell you in 2 days :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants