Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for median, p90, p95 and p99 math functions #2630

Merged
merged 2 commits into from
Dec 2, 2020
Merged

Add support for median, p90, p95 and p99 math functions #2630

merged 2 commits into from
Dec 2, 2020

Conversation

macobo
Copy link
Contributor

@macobo macobo commented Dec 2, 2020

Related issue: #2584

Screenshot from 2020-12-02 16-33-16

Checklist

  • All querysets/queries filter by Organization, by Team, and by User
  • Django backend tests
  • Jest frontend tests
  • Cypress end-to-end tests

@macobo macobo requested a review from EDsCODE December 2, 2020 14:33
@timgl timgl temporarily deployed to posthog-aggregates-8mirvxpckbg December 2, 2020 14:36 Inactive
@macobo macobo temporarily deployed to posthog-aggregates-8mirvxpckbg December 2, 2020 14:47 Inactive
@macobo macobo temporarily deployed to posthog-aggregates-8mirvxpckbg December 2, 2020 15:07 Inactive
@macobo macobo temporarily deployed to posthog-aggregates-8mirvxpckbg December 2, 2020 15:13 Inactive
EDsCODE
EDsCODE approved these changes Dec 2, 2020
View reviewed changes
Copy link
Member

@EDsCODE EDsCODE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm very clean extension!

@macobo macobo merged commit a451e14 into master Dec 2, 2020
@macobo macobo deleted the aggregates branch December 2, 2020 15:22
@paolodamico paolodamico mentioned this pull request Jan 25, 2021
Closed
@Twixes Twixes mentioned this pull request Apr 29, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EDsCODE EDsCODE EDsCODE approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@macobo @EDsCODE @timgl