Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redis warning #1856

Merged
merged 2 commits into from
Oct 14, 2020
Merged

Remove redis warning #1856

merged 2 commits into from
Oct 14, 2020

Conversation

timgl
Copy link
Collaborator

@timgl timgl commented Oct 13, 2020

Changes

Please describe.
If this affects the front-end, include screenshots.

Checklist

  • All querysets/queries filter by Team (if this PR affects any querysets/queries)
  • Backend tests (if this PR affects the backend)
  • Cypress E2E tests (if this PR affects the front and/or backend)

@timgl timgl temporarily deployed to posthog-remove-redis-wa-yizzo0 October 13, 2020 15:22 Inactive
@timgl timgl temporarily deployed to posthog-remove-redis-wa-yizzo0 October 13, 2020 15:23 Inactive
@mariusandra
Copy link
Collaborator

How come? People who have gotten this warning have had issues with their setup if I recall correctly... and we don't really know for how many people this has helped ensure their setup is legit, or do we?

@timgl
Copy link
Collaborator Author

timgl commented Oct 13, 2020

I have seen a ton of instances where PostHog was working normally but people would consistently get this error, and has caused a ton of confusion. I spent some time a while ago trying to debug this but couldn't find a root cause. At this point, we can assume anyone installing PostHog will have a worker setup correctly. We can return this error message in the 'status'/debug page in #1812.

@mariusandra
Copy link
Collaborator

I get the point, as since if you don't have redis, events are not ingested and it's quite obvious something is broken.

As a first change though I would have changed the heartbeat > 90 to something like heartbeat > 900 to see if that fixes the problem. If there's no ping in 15min, it's probably worth showing a warning sign with a link to the upcoming stats/debug page.

@yakkomajuri
Copy link
Contributor

Yeah, it's a common and very annoying problem #1523. Increasing the time for the heartbeat check could be something.

@mariusandra
Copy link
Collaborator

Fine to remove it from my side.

Would be good to have an alert somewhere prominent once #1812 goes live and an issue is detected. Be it redis being down or "your database is getting too large for this instance".

@timgl timgl merged commit da88897 into master Oct 14, 2020
@timgl timgl deleted the remove-redis-warning branch October 14, 2020 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants