fix(recording-ingester): handle concurrency, retries + incomplete events in the ingester #11022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hazzadous
approved these changes
Jul 28, 2022
hazzadous
reviewed
Jul 28, 2022
| const timeout_ms = | ||
| RECORDING_EVENTS_TOPICS_CONFIGS[topic as keyof typeof RECORDING_EVENTS_TOPICS_CONFIGS].timeout | ||
| if (timeout_ms !== 0) { | ||
| setTimeout(() => { |
There was a problem hiding this comment.
Rather than using setTimeout like this, can we instead pause the specific topic,partition pair as. This means we can still ensure that we process these retries in order.
Something along the lines of https://kafka.js.org/docs/consuming#a-name-pause-resume-a-pause-resume
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Add support for handling:
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
How did you test this code?