read metadata from object storage #10810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcmarron
commented
Jul 15, 2022
| def _read_for_threading(self, result: List, index: int, bucket: str, key: str): | ||
| result[index] = self.read(bucket, key) | ||
|
|
||
| def read_all(self, bucket: str, keys: List[str], max_concurrent_requests: int) -> Optional[List[Tuple[str, str]]]: |
There was a problem hiding this comment.
Theoretically, this should be fast, but in practice it is the opposite. I'm not sure why
There was a problem hiding this comment.
I guess for the metadata we don't do any progressive loading so we can't make the time to first byte really fast and therefore start playing immediately?
I'm not sure I'll be able to properly look at this today as am flying. Seems worth digging in first to where the bottleneck here is.
If all else fails we may be able to take advantage of that there is only one consumer processing messages that we can compact metadata down to one file 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the object storage read path for meta data. So, when running this branch, the front-end uses object storage for the metadata calculations, and then it does the old path for fetching the actual data. It's still a WIP, but it works in my local dev env. A couple notes:
session_recordings/...to the start of all paths in object storage, so any old data there will be brokenposthogdocker files.