Skip to content

Commit

Permalink
refactor(deploy): remove JS_URL from AWS ECS task definition (#7508)
Browse files Browse the repository at this point in the history
It was added in the hope that it would enable controlling where the JS
bundles were loaded, but [here](https://github.com/PostHog/posthog/blob/d58b141c5807fd8e0e90c5e82e40c11ffa78b4c0/frontend/utils.mjs#L72)
we can see that it is in fact a build time substitution and thus has no
use as it is.

For posthog cloud docker image this var is set [here](https://github.com/PostHog/posthog-cloud/blob/3e592205eb75bbbb07a05d359d449080eb8a354c/prod.web.Dockerfile#L3)
within the posthog cloud repo docker image.

We could make this a runtime substitution but for the time being I'll
simply update the hardcoded url to be https://app-static.posthog.com/
rather than the default cloudflare one.
  • Loading branch information
Harry Waye authored Dec 9, 2021
1 parent f69940b commit d8bf9a3
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions task-definition.web.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,6 @@
},
"essential": true,
"environment": [
{
"name": "JS_URL",
"value": "https://app-static.posthog.com"
},
{
"name": "USING_PGBOUNCER",
"value": "True"
Expand Down

0 comments on commit d8bf9a3

Please sign in to comment.