Skip to content

Commit

Permalink
chore: turn react-hook eslint rules off
Browse files Browse the repository at this point in the history
I originally turned this on in
#6571 and subsequently added a
few manual disables for historical violations in
#6576

I have not manually disabled all of the issues, which means that at the
moment for PRs we see the eslint issues for unmodified files annotation
in github.

Removing the rules entirely is a little fiddly, as by my attempt in
#6696

For now just turning the rules off should remove the noise for PRs,
which I imagine is annoying people.
  • Loading branch information
Harry Waye committed Oct 27, 2021
1 parent 8515fee commit bf7e23c
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,8 @@ module.exports = {
html: true,
},
],
'react-hooks/rules-of-hooks': 'warn',
'react-hooks/exhaustive-deps': 'warn',
'react-hooks/rules-of-hooks': 'off',
'react-hooks/exhaustive-deps': 'off',
'no-unused-vars': ['error', { ignoreRestSiblings: true }],
'@typescript-eslint/explicit-function-return-type': 'off',
'@typescript-eslint/explicit-module-boundary-types': 'off',
Expand Down

0 comments on commit bf7e23c

Please sign in to comment.