Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Flags Tutorial #438

Merged
merged 9 commits into from
Sep 24, 2020
Merged

Feature Flags Tutorial #438

merged 9 commits into from
Sep 24, 2020

Conversation

yakkomajuri
Copy link
Contributor

Adding tutorials to our Docs - currently work in progress since we would prefer to launch a few tutorials at once to populate the page.

Overall look:

Screenshot 2020-09-22 at 12 46 25

Copy link
Contributor

@jamesefhawkins jamesefhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Main one is the point on the structure. I don't think it'll change the content hugely but I think it'd make it more readable.

contents/docs/tutorials.md Show resolved Hide resolved

To find the feature flags page, click on 'Experiments' on the left sidebar in PostHog.

![Feature Flags Page](../../images/tutorials/feature-flags/feature-flags-page.png)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These images are hard to see without clicking into them because the page width is narrow. The consistency however (the whole screen each time) does make them look a lot nicer.

Could we expand the width a little?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will take a look

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can only make them marginally larger - to make them significantly bigger would actually require some deeper tweaks

contents/docs/tutorials/feature-flags.md Outdated Show resolved Hide resolved
contents/docs/tutorials/feature-flags.md Show resolved Hide resolved
contents/docs/tutorials/feature-flags.md Outdated Show resolved Hide resolved
contents/docs/tutorials/feature-flags.md Show resolved Hide resolved
contents/docs/tutorials/feature-flags.md Outdated Show resolved Hide resolved
contents/docs/tutorials/feature-flags.md Outdated Show resolved Hide resolved
contents/docs/tutorials/feature-flags.md Show resolved Hide resolved
@yakkomajuri yakkomajuri marked this pull request as draft September 22, 2020 13:51
@yakkomajuri
Copy link
Contributor Author

@jamesefhawkins take a look now - the tutorial should have incorporated your overall feedback.

I was also thinking it'd be cool to use a feature flag to release these i.e. we could merge the tutorials and just turn the flag on when we're satisfied with the number.

The problem is that using feature flags with the PostHog Gatsby plugin is a bit tricky. Will take a deeper look into it but it might just end up being too much of a hassle with the way the plugin is structured.

@yakkomajuri
Copy link
Contributor Author

yakkomajuri commented Sep 22, 2020

Managed to find a workaround.

So now I've implemented a feature flag that hides the Tutorials section from the menu until we activate it. We can therefore merge tutorials in separate PRs and just toggle that on when we're ready.

"You who caught the turtles better eat them"

i.e. It is only right we make use of our own functionality ("We use PostHog to track PostHog")

@yakkomajuri yakkomajuri changed the title [WIP] Feature Tutorials Feature Flags Tutorial Sep 23, 2020
@yakkomajuri yakkomajuri marked this pull request as ready for review September 23, 2020 09:26
@yakkomajuri
Copy link
Contributor Author

@jamesefhawkins Because of the feature flag, this should be ready to go by itself

@yakkomajuri
Copy link
Contributor Author

@yakkomajuri yakkomajuri mentioned this pull request Sep 23, 2020
Copy link
Contributor

@jamesefhawkins jamesefhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Yakko! I fixed a conflict with the sidebar, I'm now just waiting to check the build then happy for you to merge.

@yakkomajuri yakkomajuri merged commit 8519158 into master Sep 24, 2020
@yakkomajuri yakkomajuri deleted the feature-tutorials branch September 24, 2020 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants