-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Flags Tutorial #438
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Main one is the point on the structure. I don't think it'll change the content hugely but I think it'd make it more readable.
|
||
To find the feature flags page, click on 'Experiments' on the left sidebar in PostHog. | ||
|
||
![Feature Flags Page](../../images/tutorials/feature-flags/feature-flags-page.png) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These images are hard to see without clicking into them because the page width is narrow. The consistency however (the whole screen each time) does make them look a lot nicer.
Could we expand the width a little?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will take a look
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can only make them marginally larger - to make them significantly bigger would actually require some deeper tweaks
@jamesefhawkins take a look now - the tutorial should have incorporated your overall feedback. I was also thinking it'd be cool to use a feature flag to release these i.e. we could merge the tutorials and just turn the flag on when we're satisfied with the number. The problem is that using feature flags with the PostHog Gatsby plugin is a bit tricky. Will take a deeper look into it but it might just end up being too much of a hassle with the way the plugin is structured. |
Managed to find a workaround. So now I've implemented a feature flag that hides the Tutorials section from the menu until we activate it. We can therefore merge tutorials in separate PRs and just toggle that on when we're ready. "You who caught the turtles better eat them" i.e. It is only right we make use of our own functionality ("We use PostHog to track PostHog") |
@jamesefhawkins Because of the feature flag, this should be ready to go by itself |
To find the tutorial: https://pr-438.d1armtyn8hqyjr.amplifyapp.com/docs/tutorials/feature-flags |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you Yakko! I fixed a conflict with the sidebar, I'm now just waiting to check the build then happy for you to merge.
Adding tutorials to our Docs - currently work in progress since we would prefer to launch a few tutorials at once to populate the page.
Overall look: