chore(deps): Update @sentry/types for 7.2.0 #412
Conversation
|
@mariusandra Please review. |
| @@ -851,7 +851,7 @@ declare namespace posthog { | |||
| export class SentryIntegration implements Integration { | |||
| constructor(posthog: posthog, organization?: string, projectId?: number, prefix?: string) | |||
| name: string | |||
| setupOnce(addGlobalEventProcessor: (callback: EventProcessor) => void): void | |||
| setupOnce(addGlobalEventProcessor: (callback: EventProcessor) => void, getCurrentHub: () => Hub): void | |||
There was a problem hiding this comment.
Hm, I don't think this is quite correct as we don't support getCurrentHub in
posthog-js/src/posthog-core.js
Line 1493 in 7d5eefb
What's the intention with adding this and updating types to 7.2.0?
There was a problem hiding this comment.
@Twixes in the latest release of @sentry/types 7.x.x, an additional parameter has been added in setupOnce function i.e. getCurrentHub. So due to this, I am not able to update this library to the latest version as I am using sentry postHog integration also. This update will to keep both sentry and postHog libraries to the latest versions.
and why me? :D |
I saw this PR was approved by you. So asked you to review. |
Twixes
changed the title
Changes
Update sentry function "setupOnce" declaration.
...
Checklist