-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: bump version for session length maximum #407
Conversation
Wondering if we should just edit the readme.md and put the bump label on that pr? I think the label does more stuff too - like update the version in the main PostHog repo. That's what I always do when I forget to put the label on - which seems to be half of my PRs to posthog-js 😂 |
Nope, the label only results in package.json being updated. And everything else (npm, main repo PR, etc.) occurs when package.json is updated. This is specifically so that only a one-line manual commit is required in case the label is forgotten. @rcmarron |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, the label only results in package.json being updated. And everything else (npm, main repo PR, etc.) occurs when package.json is updated. This is specifically so that only a one-line manual commit is required in case the label is forgotten. @rcmarron
Ahh got it, nice! In that case, LGTM
Changes
In PR #405 I didn't bump the version or set the bump version label on the PR 🤦