Speculative logging for PostHog/posthog#4816 #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@macobo related to the issue we discussed yesterday... I think this will send an event back to posthog when the gzip bug manifests... will it? |
macobo
reviewed
Sep 28, 2021
|
OK, so, very hacky approach @macobo. Like this? I'm thinking of minimal change to getting debug info for the linked issue Ultimately, if we want to keep the idea of a debug channel it feels wrong to hide this inside capture metrics. And would need to add a new "thing" so that users can more explicitly opt in |
pauldambra
changed the title
mariusandra
deleted the
speculative-logging-of-irreversible-compression
branch
pauldambra
added a commit
that referenced
this pull request
Sep 30, 2021
This reverts commit 5447142.
mariusandra
pushed a commit
that referenced
this pull request
Sep 30, 2021
This reverts commit 5447142.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
PostHog/posthog#4816 shows we intermittently receive unexpected values in place of gzipped content
this logging catches unexpected source or zipped data and logs it back to posthog
...
Checklist