Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 'this.people.delete_user is undefined' #113

Merged
merged 2 commits into from
Nov 12, 2020
Merged

Fix 'this.people.delete_user is undefined' #113

merged 2 commits into from
Nov 12, 2020

Conversation

macobo
Copy link
Contributor

@macobo macobo commented Nov 11, 2020

Fixes issue #39

Relevant code in people was removed in commit
b6b39a9, we don't handle $delete events
in our capture backend.

Changes

...

Checklist

  • Tests for new code (if applicable)
  • TypeScript definitions (module.d.ts) updated and in sync with library exports (if applicable)

@macobo
Remove dead code
cfb2a5f 
Fixes issue #39

Relevant code in people was removed in commit
b6b39a9, we don't handle $delete events
in our capture backend.
@macobo
kill now-dead flag/function
d32a862
@macobo macobo requested a review from mariusandra November 11, 2020 13:52
mariusandra
mariusandra approved these changes Nov 12, 2020
View reviewed changes
Copy link
Collaborator

@mariusandra mariusandra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@macobo macobo merged commit 8f43f25 into master Nov 12, 2020
@macobo macobo deleted the fix-39 branch November 12, 2020 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariusandra mariusandra mariusandra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@macobo @mariusandra