-
Notifications
You must be signed in to change notification settings - Fork 143
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(identify): actually send $set_once on identify calls (#629)
We were handling $set but not $set_once. This fixes that. Fixes #615
- v1.225.1
- v1.225.0
- v1.224.1
- v1.224.0
- v1.223.5
- v1.223.4
- v1.223.3
- v1.223.2
- v1.223.1
- v1.222.0
- v1.221.1
- v1.221.0
- v1.220.0
- v1.219.6
- v1.219.5
- v1.219.4
- v1.219.3
- v1.219.2
- v1.219.1
- v1.219.0
- v1.218.2
- v1.218.1
- v1.218.0
- v1.217.7
- v1.217.6
- v1.217.5
- v1.217.4
- v1.217.3
- v1.217.2
- v1.217.1
- v1.217.0
- v1.216.1
- v1.216.0
- v1.215.7
- v1.215.6
- v1.215.5
- v1.215.4
- v1.215.3
- v1.215.2
- v1.215.1
- v1.215.0
- v1.214.1
- v1.214.0
- v1.213.0
- v1.212.1
- v1.212.0
- v1.211.4
- v1.211.3
- v1.211.2
- v1.211.1
- v1.211.0
- v1.210.2
- v1.210.1
- v1.210.0
- v1.209.4
- v1.209.3
- v1.209.2
- v1.209.1
- v1.209.0
- v1.208.1
- v1.208.0
- v1.207.9
- v1.207.8
- v1.207.7
- v1.207.6
- v1.207.5
- v1.207.4
- v1.207.3
- v1.207.2
- v1.207.1
- v1.207.0
- v1.206.1
- v1.206.0
- v1.205.1
- v1.205.0
- v1.204.0
- v1.203.3
- v1.203.2
- v1.203.1
- v1.203.0
- v1.202.5
- v1.202.4
- v1.202.2
- v1.202.1
- v1.202.0
- v1.201.1
- v1.201.0
- v1.200.2
- v1.200.1
- v1.200.0
- v1.199.0
- v1.198.0
- v1.197.0
- v1.196.1
- v1.196.0
- v1.195.0
- v1.194.6
- v1.194.5
- v1.194.4
- v1.194.3
- v1.194.2
- v1.194.1
- v1.194.0
- v1.193.1
- v1.193.0
- v1.192.1
- v1.192.0
- v1.191.0
- v1.190.2
- v1.190.1
- v1.190.0
- v1.189.1
- v1.189.0
- v1.188.1
- v1.188.0
- v1.187.2
- v1.187.1
- v1.187.0
- v1.186.4
- v1.186.3
- v1.186.2
- v1.186.1
- v1.186.0
- v1.185.0
- v1.184.2
- v1.184.1
- v1.184.0
- v1.183.0
- v1.182.0
- v1.181.0
- v1.180.1
- v1.180.0
- v1.179.0
- v1.178.0
- v1.177.0
- v1.176.1
- v1.176.0
- v1.175.1
- v1.175.0
- v1.174.4
- v1.174.3
- v1.174.2
- v1.174.1
- v1.174.0
- v1.173.0
- v1.172.1
- v1.172.0
- v1.171.0
- v1.170.1
- v1.170.0
- v1.169.1
- v1.169.0
- v1.168.0
- v1.167.1
- v1.167.0
- v1.166.2
- v1.166.1
- v1.166.0
- v1.165.1
- v1.165.0
- v1.164.3
- v1.164.2
- v1.164.1
- v1.164.0
- v1.163.1
- v1.163.0
- v1.162.0
- v1.161.6
- v1.161.5
- v1.161.4
- v1.161.3
- v1.161.2
- v1.161.1
- v1.161.0
- v1.160.3
- v1.160.2
- v1.160.1
- v1.160.0
- v1.159.0
- v1.158.3
- v1.158.2
- v1.158.1
- v1.158.0
- v1.157.2
- v1.157.1
- v1.157.0
- v1.156.1
- v1.156.0
- v1.155.6
- v1.155.5
- v1.155.4
- v1.155.3
- v1.155.2
- v1.155.1
- v1.155.0
- v1.154.6
- v1.154.5
- v1.154.4
- v1.154.3
- v1.154.2
- v1.154.1
- v1.154.0
- v1.153.0
- v1.152.1
- v1.152.0
- v1.151.2
- v1.151.1
- v1.151.0
- v1.150.1
- v1.150.0
- v1.149.2
- v1.149.1
- v1.149.0
- v1.148.2
- v1.148.1
- v1.148.0
- v1.147.0
- v1.146.3
- v1.146.2
- v1.146.1
- v1.146.0
- v1.145.1
- v1.145.0
- v1.144.2
- v1.144.1
- v1.144.0
- v1.143.0
- v1.142.1
- v1.142.0
- v1.141.4
- v1.141.3
- v1.141.2
- v1.141.1
- v1.141.0
- v1.140.1
- v1.140.0
- v1.139.8
- v1.139.7
- v1.139.6
- v1.139.5
- v1.139.4
- v1.139.3
- v1.139.2
- v1.139.1
- v1.139.0
- v1.138.3
- v1.138.2
- v1.138.1
- v1.138.0
- v1.137.0
- v1.136.8
- v1.136.7
- v1.136.6
- v1.136.5
- v1.136.4
- v1.136.3
- v1.136.2
- v1.136.1
- v1.136.0
- v1.135.2
- v1.135.1
- v1.135.0
- v1.134.0
- v1.133.0
- v1.132.3
- v1.132.2
- v1.132.1
- v1.132.0
- v1.131.4
- v1.131.3
- v1.131.2
- v1.131.1
- v1.131.0
- v1.130.2
- v1.130.1
- v1.130.0
- v1.129.0
- v1.128.5
- v1.128.4
- v1.128.3
- v1.128.2
- v1.128.1
- v1.128.0
- v1.127.0
- v1.126.0
- v1.125.0
- v1.124.0
- v1.123.1
- v1.123.0
- v1.122.0
- v1.121.4
- v1.121.3
- v1.121.2
- v1.121.1
- v1.121.0
- v1.120.5
- v1.120.4
- v1.120.3
- v1.120.2
- v1.120.1
- v1.120.0
- v1.119.2
- v1.119.1
- v1.119.0
- v1.118.1
- v1.118.0
- v1.117.2
- v1.117.1
- v1.117.0
- v1.116.7
- v1.116.6
- v1.116.5
- v1.116.4
- v1.116.3
- v1.116.2
- v1.116.1
- v1.116.0
- v1.115.2
- v1.115.1
- v1.115.0
- v1.114.2
- v1.114.1
- v1.114.0
- v1.113.4
- v1.113.3
- v1.113.2
- v1.113.1
- v1.113.0
- v1.112.1
- v1.112.0
- v1.111.3
- v1.111.2
- v1.111.1
- v1.111.0
- v1.110.0
- v1.109.0
- v1.108.4
- v1.108.3
- v1.108.2
- v1.108.1
- v1.108.0
- v1.107.0
- v1.106.3
- v1.106.2
- v1.106.1
- v1.106.0
- v1.105.9
- v1.105.8
- v1.105.7
- v1.105.6
- v1.105.5
- v1.105.4
- v1.105.3
- v1.105.0
- v1.104.4
- v1.104.3
- v1.104.2
- v1.104.1
- v1.104.0
- v1.103.2
- v1.103.1
- v1.103.0
- v1.102.1
- v1.102.0
- v1.101.0
- v1.100.0
- v1.99.0
- v1.98.2
- v1.98.1
- v1.98.0
- v1.97.1
- v1.97.0
- v1.96.1
- v1.96.0
- v1.95.1
- v1.95.0
- v1.94.4
- v1.94.3
- v1.94.2
- v1.94.1
- v1.94.0
- v1.93.6
- v1.93.5
- v1.93.4
- v1.93.3
- v1.93.2
- v1.93.1
- v1.93.0
- v1.92.1
- v1.92.0
- v1.91.1
- v1.91.0
- v1.90.2
- v1.90.1
- v1.90.0
- v1.89.2
- v1.89.1
- v1.89.0
- v1.88.4
- v1.88.3
- v1.88.2
- v1.88.1
- v1.88.0
- v1.87.6
- v1.87.5
- v1.87.4
- v1.87.3
- v1.87.2
- v1.87.1
- v1.87.0
- v1.86.0
- v1.85.4
- v1.85.3
- v1.85.2
- v1.85.1
- v1.85.0
- v1.84.4
- v1.84.3
- v1.84.2
- v1.84.1
- v1.84.0
- v1.83.3
- v1.83.2
- v1.83.1
- v1.83.0
- v1.82.3
- v1.82.2
- v1.82.1
- v1.82.0
- v1.81.4
- v1.81.3
- v1.81.2
- v1.81.1
- v1.81.0
- v1.80.0
- v1.79.1
- v1.79.0
- v1.78.6
- v1.78.5
- v1.78.4
- v1.78.3
- v1.78.2
- v1.78.1
- v1.78.0
- v1.77.3
- v1.77.2
- v1.77.1
- v1.77.0
- v1.76.0
- v1.75.4
- v1.75.3
- v1.75.2
- v1.75.1
- v1.75.0
- v1.74.0
- v1.73.1
- v1.73.0
- v1.72.3
- v1.72.2
- v1.72.1
- v1.72.0
- v1.71.0
- v1.70.2
- v1.70.1
- v1.70.0
- v1.69.0
- v1.68.5
- v1.68.4
- v1.68.3
- v1.68.2
- v1.68.1
- v1.68.0
- v1.67.1
- v1.67.0
- v1.66.1
- v1.66.0
- v1.65.0
- v1.64.0
- v1.63.6
- v1.63.5
- v1.63.4
- v1.63.3
- v1.63.2
- v1.63.1
- v1.63.0
- v1.62.0
- v1.61.0
- v1.60.0
- v1.59.0
- v1.58.0
- v1.57.4
- v1.57.3
- v1.57.2
- v1.57.1
- 1.105.7
Showing
3 changed files
with
25 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -129,6 +129,28 @@ describe('capture()', () => { | |
const event = given.subject() | ||
expect(event.properties.key.length).toBe(50000) | ||
}) | ||
|
||
it('passes through $set and $set_once into the request, if the event is an $identify event', () => { | ||
// NOTE: this is slightly unusual to test capture for this specific case | ||
// of being called with $identify as the event name. It might be that we | ||
// decide that this shouldn't be a special case of capture in this case, | ||
// but I'll add the case to capture current functionality. | ||
// | ||
// We check that if identify is called with user $set and $set_once | ||
// properties, we also want to ensure capture does the expected thing | ||
// with them. | ||
const captureResult = given.lib.capture( | ||
'$identify', | ||
{ distinct_id: 'some-distinct-id' }, | ||
{ $set: { email: '[email protected]' }, $set_once: { howOftenAmISet: 'once!' } } | ||
) | ||
|
||
// We assume that the returned result is the object we would send to the | ||
// server. | ||
expect(captureResult).toEqual( | ||
expect.objectContaining({ $set: { email: '[email protected]' }, $set_once: { howOftenAmISet: 'once!' } }) | ||
) | ||
}) | ||
}) | ||
|
||
describe('_calculate_event_properties()', () => { | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters