fix: never send when not sampled

src/__tests__/extensions/replay/sessionrecording.test.ts

@@ -2437,5 +2437,19 @@ describe('SessionRecording', () => {
             // even though still waiting for URL to trigger
             expect(sessionRecording['status']).toBe('active')
         })
+
+        it('ANDS with Sampling', async () => {
+            sessionRecording.onRemoteConfig(
+                makeDecideResponse({
+                    sessionRecording: {
+                        endpoint: '/s/',
+                        eventTriggers: ['$exception'],
+                        sampleRate: '0.00', // i.e. never send recording
+                    },
+                })
+            )
+
+            expect(sessionRecording['status']).toBe('disabled')
+        })
     })
 })

src/extensions/replay/sessionrecording.ts

@@ -397,6 +397,12 @@ export class SessionRecording {
             return 'disabled'
         }
 
+        // if sampling is set and the session is already decided to not be sampled
+        // then we should never be active
+        if (this.isSampled === false) {
+            return 'disabled'
+        }
+
         if (this._urlBlocked) {
             return 'paused'
         }