Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add loadFeatureFlagsOnStart configuration flag #71

Merged
merged 4 commits into from
Oct 9, 2023

Conversation

marioradonic
Copy link
Contributor

What does this PR do?

It adds a configuration flag similar to JS library's advanced_disable_feature_flags_on_first_load with which a first load of feature flags can be disabled.

Where should the reviewer start?

Not much to this PR. Variable name can be discussed and I'm not sure if this is the best way to write the test, but I've tried to follow current structure. I didn't wanna name the variable the same as it's in JS lib since in iOS we don't have a "page load" concept.

How should this be manually tested?

I tested it manually by intercepting http requests using Charles proxy and confirming that /decide call is not made.

Any background context you want to provide?

In our project we want to be in control of when to reload feature flags. The flag is true by default so it's backward compatible.

What are the relevant tickets?
/

Screenshots or screencasts (if UI/UX change)
/

Questions:

  • Does the docs need an update?

Could be useful, but not my job.

  • Are there any security concerns?

I don't see any.

  • Do we need to update engineering / success?

/

@marandaneto marandaneto merged commit 4474be1 into PostHog:master Oct 9, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants