Add loadFeatureFlagsOnStart configuration flag #71
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It adds a configuration flag similar to JS library's
advanced_disable_feature_flags_on_first_load
with which a first load of feature flags can be disabled.Where should the reviewer start?
Not much to this PR. Variable name can be discussed and I'm not sure if this is the best way to write the test, but I've tried to follow current structure. I didn't wanna name the variable the same as it's in JS lib since in iOS we don't have a "page load" concept.
How should this be manually tested?
I tested it manually by intercepting http requests using Charles proxy and confirming that /decide call is not made.
Any background context you want to provide?
In our project we want to be in control of when to reload feature flags. The flag is true by default so it's backward compatible.
What are the relevant tickets?
/
Screenshots or screencasts (if UI/UX change)
/
Questions:
Could be useful, but not my job.
I don't see any.
/