Update alias doc strings #34
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
tiina303
reviewed
Jan 24, 2023
|
|
||
| @param alias The new ID you want to alias the existing ID to. The existing ID will be either the | ||
| previousId if you have called identify, or the anonymous ID. | ||
| @param alias The alias ID that you want to attach to the user |
There was a problem hiding this comment.
let's be more clear here - this needs to be the anonymous ID (that hasn't been merged with anything else). Please see https://posthog.com/docs/integrate/server/node#alias for example. what "alias ID" is is not clear.
There was a problem hiding this comment.
I didn't realize this was the case, I've asked a question here: PostHog/posthog-python#82 (comment)
|
Closed in favor of https://github.com/PostHog/posthog-ios/releases/tag/3.0.0-alpha.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Update the alias doc string to match how aliasing actually works. It was implying the wrong order