Do not capture console logs and network requests if session replay and session are not active #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d session are not active
marandaneto
commented
Jan 17, 2024
| import com.posthog.android.PostHogAndroidConfig | ||
| import com.posthog.internal.interruptSafely | ||
| import com.posthog.internal.replay.RRPluginEvent | ||
| import com.posthog.internal.replay.capture | ||
| import java.text.SimpleDateFormat | ||
| import java.util.Locale | ||
|
|
||
| internal class PostHogLogCatWatcher(private val config: PostHogAndroidConfig) { | ||
| internal class PostHogLogCatIntegration(private val config: PostHogAndroidConfig) : PostHogIntegration { |
There was a problem hiding this comment.
the logcat integration now is totally decoupled from the app lifecycle and session replay integration, its installed but only captures something if the session is active and replay is enabled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
If session replay was disabled or session not active, console logs and network requests were still captured since the check was done only early in the app lifecycle.
💚 How did you test it?
Running both with session replay and session active and not active
📝 Checklist