Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: screenshot masking #145

Merged
merged 9 commits into from
Jun 20, 2024
Merged

chore: screenshot masking #145

merged 9 commits into from
Jun 20, 2024

Conversation

marandaneto
Copy link
Member

@marandaneto marandaneto commented Jun 19, 2024 •
edited
Loading

💡 Motivation and Context

chore: screenshot masking

💚 How did you test it?

running with and w/o masking enabled.
we don't have UI tests set up yet to validate the changes.

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • I updated the docs if needed. - will update once its merged/released.
  • No breaking change or entry added to the changelog.

@marandaneto marandaneto requested a review from a team June 20, 2024 07:27
@marandaneto marandaneto marked this pull request as ready for review June 20, 2024 07:28
@marandaneto marandaneto mentioned this pull request Jun 20, 2024
Closed
pauldambra
pauldambra approved these changes Jun 20, 2024
View reviewed changes
Copy link
Member

@pauldambra pauldambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@marandaneto marandaneto merged commit 608d0cd into main Jun 20, 2024
8 checks passed
@marandaneto marandaneto deleted the chore/screenshot-masking branch June 20, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pauldambra pauldambra pauldambra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marandaneto @pauldambra