Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: PostHogLogger possibly leaks this ctor and crash #140

Merged
merged 2 commits into from
Jun 11, 2024

Conversation

marandaneto
Copy link
Member

💡 Motivation and Context

https://stackoverflow.com/questions/3921616/leaking-this-in-constructor-warning
https://stackoverflow.com/questions/9851813/java-leaking-this-in-constructor/9851843#9851843
https://stackoverflow.com/questions/53866865/leaking-this-in-constructor-warning-should-apply-to-final-classes-as-well-as

Maybe fixes #135

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • I updated the docs if needed.
  • No breaking change or entry added to the changelog.

@marandaneto marandaneto marked this pull request as ready for review June 11, 2024 07:06
@marandaneto marandaneto requested a review from a team June 11, 2024 07:06
@marandaneto marandaneto merged commit 895429f into main Jun 11, 2024
6 checks passed
@marandaneto marandaneto deleted the fix/leak-this-logger branch June 11, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

java.lang.InstantiationError crash in prod during posthog init
2 participants