Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rename groupProperties to groups for capture methods #139

Merged
merged 5 commits into from
Jun 6, 2024

Conversation

marandaneto
Copy link
Member

@marandaneto marandaneto commented Jun 3, 2024

💡 Motivation and Context

Fix found by #129

It's a breaking change but also a fix so not worth raising a major.
We didn't mention it in the docs either, it's just the name of the property and its type.
I'll change it in iOS as well.

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • I updated the docs if needed.
  • No breaking change or entry added to the changelog.

@marandaneto marandaneto marked this pull request as ready for review June 3, 2024 15:51
@marandaneto marandaneto requested a review from a team June 3, 2024 16:05
@marandaneto marandaneto merged commit 4098fa7 into main Jun 6, 2024
5 checks passed
@marandaneto marandaneto deleted the fix/capture-groups branch June 6, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants