Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

recording: fix removing the ViewTreeObserver when its not alive #134

Merged
merged 3 commits into from
May 24, 2024
Merged

recording: fix removing the ViewTreeObserver when its not alive #134

merged 3 commits into from
May 24, 2024

Conversation

marandaneto
Copy link
Member

@marandaneto marandaneto commented May 24, 2024 •
edited
Loading

💡 Motivation and Context

Fixes #133

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • I updated the docs if needed.
  • No breaking change or entry added to the changelog.

@marandaneto marandaneto marked this pull request as ready for review May 24, 2024 06:28
@marandaneto marandaneto requested a review from a team May 24, 2024 06:28
@marandaneto
Copy link
Member Author

@pauldambra and @daibhin since you both are OOO I will YOLO this

@marandaneto marandaneto merged commit 7929663 into main May 24, 2024
6 checks passed
@marandaneto marandaneto deleted the fix/viewtree-remove branch May 24, 2024 06:33
pauldambra
pauldambra reviewed May 24, 2024
View reviewed changes
Copy link
Member

@pauldambra pauldambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

posthumous stamp of approval :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pauldambra pauldambra pauldambra left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@marandaneto @pauldambra