Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow anonymous uuid generation to be customizable #132

Merged
merged 7 commits into from
May 21, 2024

Conversation

jimexist
Copy link
Contributor

@jimexist jimexist commented May 20, 2024

💡 Motivation and Context

this makes it aligned with the js/ts sdk

💚 How did you test it?

unit test

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • I updated the docs if needed.
  • No breaking change or entry added to the changelog.

@marandaneto
Copy link
Member

@jimexist thanks for the PR.
I left 2 more comments, please add a https://github.com/PostHog/posthog-android/blob/main/CHANGELOG.md#next entry under the Next section.

jimexist and others added 2 commits May 21, 2024 16:21
CHANGELOG.md Outdated Show resolved Hide resolved
@marandaneto
Copy link
Member

@jimexist run make api and commit/push the changes, I tried to do it myself but jimexist/main (permission denied).

@marandaneto marandaneto reopened this May 21, 2024
@marandaneto marandaneto merged commit 0f4d8b0 into PostHog:main May 21, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants