-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automagically load popups when needed #926
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fpcorso
changed the title
[WIP] Automagically load popups when found in content
[WIP] Automagically load popups when needed
Dec 22, 2020
Since we are using this code in several places, and may add more, lets create its own method for this.
The preload_popup method will add multiple instances of the popup code which results in flashes and multiple open/closes which prevents the popup from opening. Add conditional to make sure the popup isn't already loaded.
The original solution only caught when they used our popup setting for triggering popups. But, they can also add the popmake- class instead. So, we now check the classes after we set ours.
fpcorso
changed the title
[WIP] Automagically load popups when needed
Automagically load popups when needed
Dec 22, 2020
danieliser
reviewed
Dec 22, 2020
fpcorso
commented
Dec 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Automatically load when we detect that a popup is needed.
Enqueue popups when found in the_content
Used the following content to test regex:
Enqueue popups when found in the menu
Automatically loads a popup when we detect the menu item has a popup ID in the menu setting.
Enqueue popups when popup_trigger is used
If popup_trigger shortcode is used, go ahead and ensure the popup gets loaded.
Related Issue
Issue: #543
Types of changes
Filters
the_content
and search for popmake-### class. If found, load the popup. When processing menu items, if a popup ID is set, go ahead and load the popup.This has been tested in the following browsers
Checklist: