-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some form integrations are calling both AJAX and PHP submission handlers #887
Comments
I think the best option here is to add an extra value to the |
@danieliser I think you confused this issue with the other one relating to PHP submission sending data to the front-end, which has already been resolved. This would not be solved by any So, during the form submission, it currently goes:
The solution that you proposed in Slack is the one I listed in this issue. |
…mine if we should process the submission Since we repeat the same code for getting the popup ID and for increasing the conversion in all integrations, we should also move that here in case we need to change how that works in the future. Issue #887
Describe the bug
Some of our form integrations, including CF7 and WPForms, are calling both our AJAX and PHP submission handlers resulting in duplicate processes for cookie creation and conversion counts.
Site information
Popup Maker version: 1.12.0
WordPress version: 5.5.1
PHP version: 7.4.1
Proposed Solution
We should have a method in the abstract form integration class that will check if it's an AJAX or REST call. We then use that method within each form integration to determine if we should process the form submission.
The text was updated successfully, but these errors were encountered: