Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new minimal popup theme for page builders #759

Closed
danieliser opened this issue Feb 25, 2020 · 16 comments
Closed

Add new minimal popup theme for page builders #759

danieliser opened this issue Feb 25, 2020 · 16 comments

Comments

@danieliser
Copy link
Member

No description provided.

@fpcorso
Copy link
Contributor

fpcorso commented Mar 5, 2020

@danieliser Can you provide a little more details here? What would this new theme be and how would it be implemented? Would the site admin need to do anything with these themes?

@danieliser
Copy link
Member Author

Sure, when I use a page builder I have to make a custom theme that has no padding, no background, minimal close button etc.

Essentally a transparent container.

@fpcorso fpcorso added this to the v1.12 milestone Jun 5, 2020
@fpcorso fpcorso modified the milestones: v1.12, v1.13 Jun 15, 2020
@fpcorso fpcorso changed the title Add new theme for page builders Add new minimal popup theme for page builders Jul 1, 2020
@fpcorso fpcorso modified the milestones: v1.13, v1.12 Jul 1, 2020
@fpcorso
Copy link
Contributor

fpcorso commented Jul 20, 2020

@danieliser What do you think a good name for this theme would be? I was originally thinking "Minimal" or similar but that could be confused with a normal minimal theme designed for normal popups. Probably want to make it clear that this popup theme is designed for content from page builders or similar systems.

@danieliser
Copy link
Member Author

Yea I'm thinking name it Builder, or Page Builder, or maybe something generic like "Content Only"

@fpcorso
Copy link
Contributor

fpcorso commented Aug 6, 2020

@danieliser Should we explicitly state for use with page builders? Not sure "Content Only" or similar names will help people connect that they can use this theme with page builder content.

Something like "Content Only (For use with page builder content)"

@danieliser
Copy link
Member Author

If you think it makes it more clear then sure.

@fpcorso
Copy link
Contributor

fpcorso commented Aug 19, 2020

@danieliser Can I get your thoughts on these questions:

  1. Should all drop-shadow related settings for the container background be 0?
  2. Should background opacity be 0?
  3. Should we keep the overlay default at 100% still since they won't be editing the overlay in a page builder?
  4. Should we adjust any of the title/content settings at all?
  5. Should we adjust the close button settings?

I am assuming the answers to the first three are yes but wanted to double-check. For the close button, it seems weird to have a large green button floating there if we keep it the defaults but not sure what we'd change it to since they need to have a close button in the core version.

@danieliser
Copy link
Member Author

  1. Should all drop-shadow related settings for the container background be 0?

By default that would make it have no shadow, so yea, the page builder can do shadows on individual blocks, columns and rows.

  1. Should background opacity be 0?

Either set it to 0 or set the background color to ''

  1. Should we keep the overlay default at 100% still since they won't be editing the overlay in a page builder?

IDK, the default likely shouldn't be 100% though, these days maybe 70-80% with a dark overlay like a light box etc.

  1. Should we adjust any of the title/content settings at all?

Maybe set them all to inherit.

  1. Should we adjust the close button settings?

Possibly to make sure it is decently contrasted on as many common colors as possible and maybe positioned ouside the popup slightly?

@fpcorso
Copy link
Contributor

fpcorso commented Aug 20, 2020

@danieliser Okay, adjusted everything and playing with the close button now. Here is a quick Elementor template I built with a border so I could see spacing around template in the popup.
image

For the close button, maybe something minimal like with our newer floating bar theme. In the screenshot, I currently have just a bold, black × close button. Not sure about defaulting with a border (round or square) as it's difficult to guess exactly what type of templates people would be using.

I'm assuming there will be more squared popups so maybe a square border on the close button might be appropriate. As for inside or outside, I think more of the popups created usually have the close button inside the popup.

@danieliser
Copy link
Member Author

danieliser commented Aug 20, 2020

Looks great, we might want to make the font size quite a bit larger by default, maybe even 2x what it is now.

Wonder if we should offer 2 versions: Dark & Light to give contrast with both types of content.

@fpcorso
Copy link
Contributor

fpcorso commented Aug 20, 2020

@danieliser Just to clarify: You're saying to increase the font size of the close button, right?

As for the Dark and Light: What would be different between them other than only the close button?

@danieliser
Copy link
Member Author

@fpcorso Yes I think its a bit small for common use cases & accessibility.

Correct, would just be the close button color really, but there is no easy way currently to change just that on a per popup basis. So if you had a dark popup and a light popup, you would need 2 themes.

Adding both by default means it should offer something for any site out of the box.

@fpcorso
Copy link
Contributor

fpcorso commented Aug 20, 2020

@danieliser I don't know. The majority of the time, they will only need one version. So, would it be better to just provide one, especially if they are nearly identical? They could edit the theme and change the close button, if needed.

It may be confusing to have to "Content Only" themes with one dark and one light. The admin wouldn't know what the differences were and would have to hunt down the documentation or test out both.

@danieliser
Copy link
Member Author

Point taken, not sure the right answer, mainly because we have users who didn't know about the theme editor for years. Some still don't haha.

@fpcorso
Copy link
Contributor

fpcorso commented Sep 1, 2020

@danieliser Maybe a good first intermediate step is to just release the current "Content Only" I have and see if anyone even uses it. If we see it does gain traction, maybe we then plan on releasing a couple of different variations of it.

@danieliser
Copy link
Member Author

Sounds good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants