-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow viewing PUM_Logging log file contents via Popup Maker -> Tools #575
Comments
@danieliser What are your thoughts on this? Adding this would make it easier to ask for them in support as opposed to asking them to go to /wp-content/xxxx.log Would it be limited in someway? Maybe only show the first XXXXX lines? |
|
That said I wonder if we could start leveraging the API server and making it so they can do something like this:
I've thought about building a "Allow support to login to my site" but I wouldn't want it in the core plugin purely due to the risks that I never want to deal with. But we could do something along these lines. Alternatively if they are already opted into telemetry we should probably already be sending those logs to our servers for processing to find these issues before others do. I think we can even capture fatal PHP & JS errors from our own files and send them to our debug logs when we get around to rewriting those per another issue. |
@danieliser To keep this issue clear, let's discuss your second comment in a different thread/issue. But, yes, I think there is something to having a support request from within the plugin. For this issue, I think making it an option as a downloadable file is a good idea. Where should this go? Can we add a new "Error Log" tab to the "Tools" page? So it would be "Beta Versions" "System Info" "Error Log" and "Import / Export" as tabs on that page? Then, on that tab, maybe we show the X recent (de-duplicated, if possible) with a download error log button underneath, similar to the "System Info" page: |
@fpcorso sounds good |
Also includes some code quality improvements from PHPCS. Issue #575
To better organize this class, let's group the main methods at the top and move the helpers underneath. Issue #575
To make the methods more consistent, created a new method in the similar TAB_display style as the other methods. Issue #575
Also, fixes some warnings from StyleLint. Issue #575
@danieliser This is where I am currently at. Since this is currently the only place within the admin to control the log, should we also have a button to empty the log? |
@fpcorso Button to empty it would be simple enough and a good addition. Looks good. |
We quietly added PUM_Logging for errors and warnings to v1.7. Now we need to add a way to view those logs.
The text was updated successfully, but these errors were encountered: