Override tests that need explicit sorting for MariaDB.

PomeloFoundation · Oct 7, 2021 · 9e789c4 · 9e789c4
1 parent 9274e8e
commit 9e789c4
Showing 1 changed file with 119 additions and 0 deletions.
diff --git a/test/EFCore.MySql.FunctionalTests/Query/NorthwindMiscellaneousQueryMySqlTest.cs b/test/EFCore.MySql.FunctionalTests/Query/NorthwindMiscellaneousQueryMySqlTest.cs
@@ -223,6 +223,125 @@ public override Task Using_static_string_Equals_with_StringComparison_throws_inf
                 MySqlStrings.QueryUnableToTranslateMethodWithStringComparison(nameof(String), nameof(string.Equals), nameof(MySqlDbContextOptionsBuilder.EnableStringComparisonTranslations)));
         }
 
+        /// <summary>
+        /// Needs explicit ordering of ProductIds to work with MariaDB.
+        /// </summary>
+        public override async Task Projection_skip_collection_projection(bool async)
+        {
+            // await base.Projection_skip_collection_projection(async);
+            await AssertQuery(
+                async,
+                ss => ss.Set<Order>()
+                    .Where(o => o.OrderID < 10300)
+                    .OrderBy(o => o.OrderID)
+                    .Select(o => new { Item = o })
+                    .Skip(5)
+                    .Select(e => new { e.Item.OrderID, ProductIds = e.Item.OrderDetails.OrderBy(od => od.ProductID).Select(od => od.ProductID).ToList() }), // added .OrderBy(od => od.ProductID)
+                assertOrder: true,
+                elementAsserter: (e, a) =>
+                {
+                    Assert.Equal(e.OrderID, a.OrderID);
+                    AssertCollection(e.ProductIds, a.ProductIds, ordered: true, elementAsserter: (ie, ia) => Assert.Equal(ie, ia));
+                });
+
+            AssertSql(
+                @"@__p_0='5'
+
+SELECT `t`.`OrderID`, `t0`.`ProductID`, `t0`.`OrderID`
+FROM (
+    SELECT `o`.`OrderID`
+    FROM `Orders` AS `o`
+    WHERE `o`.`OrderID` < 10300
+    ORDER BY `o`.`OrderID`
+    LIMIT 18446744073709551610 OFFSET @__p_0
+) AS `t`
+LEFT JOIN (
+    SELECT `o0`.`ProductID`, `o0`.`OrderID`
+    FROM `Order Details` AS `o0`
+) AS `t0` ON `t`.`OrderID` = `t0`.`OrderID`
+ORDER BY `t`.`OrderID`, `t0`.`ProductID`");
+        }
+
+        /// <summary>
+        /// Needs explicit ordering of ProductIds to work with MariaDB.
+        /// </summary>
+        public override async Task Projection_skip_take_collection_projection(bool async)
+        {
+            // await base.Projection_skip_take_collection_projection(async);
+            await AssertQuery(
+                async,
+                ss => ss.Set<Order>()
+                    .Where(o => o.OrderID < 10300)
+                    .OrderBy(o => o.OrderID)
+                    .Select(o => new { Item = o })
+                    .Skip(5)
+                    .Take(10)
+                    .Select(e => new { e.Item.OrderID, ProductIds = e.Item.OrderDetails.OrderBy(od => od.ProductID).Select(od => od.ProductID).ToList() }), // added .OrderBy(od => od.ProductID)
+                assertOrder: true,
+                elementAsserter: (e, a) =>
+                {
+                    Assert.Equal(e.OrderID, a.OrderID);
+                    AssertCollection(e.ProductIds, a.ProductIds, ordered: true, elementAsserter: (ie, ia) => Assert.Equal(ie, ia));
+                });
+
+            AssertSql(
+                @"@__p_1='10'
+@__p_0='5'
+
+SELECT `t`.`OrderID`, `t0`.`ProductID`, `t0`.`OrderID`
+FROM (
+    SELECT `o`.`OrderID`
+    FROM `Orders` AS `o`
+    WHERE `o`.`OrderID` < 10300
+    ORDER BY `o`.`OrderID`
+    LIMIT @__p_1 OFFSET @__p_0
+) AS `t`
+LEFT JOIN (
+    SELECT `o0`.`ProductID`, `o0`.`OrderID`
+    FROM `Order Details` AS `o0`
+) AS `t0` ON `t`.`OrderID` = `t0`.`OrderID`
+ORDER BY `t`.`OrderID`, `t0`.`ProductID`");
+        }
+
+        /// <summary>
+        /// Needs explicit ordering of ProductIds to work with MariaDB.
+        /// </summary>
+        public override async Task Projection_take_collection_projection(bool async)
+        {
+            // await base.Projection_take_collection_projection(async);
+            await AssertQuery(
+                async,
+                ss => ss.Set<Order>()
+                    .Where(o => o.OrderID < 10300)
+                    .OrderBy(o => o.OrderID)
+                    .Select(o => new { Item = o })
+                    .Take(10)
+                    .Select(e => new { e.Item.OrderID, ProductIds = e.Item.OrderDetails.OrderBy(od => od.ProductID).Select(od => od.ProductID).ToList() }), // added .OrderBy(od => od.ProductID)
+                assertOrder: true,
+                elementAsserter: (e, a) =>
+                {
+                    Assert.Equal(e.OrderID, a.OrderID);
+                    AssertCollection(e.ProductIds, a.ProductIds, ordered: true, elementAsserter: (ie, ia) => Assert.Equal(ie, ia));
+                });
+
+            AssertSql(
+                @"@__p_0='10'
+
+SELECT `t`.`OrderID`, `t0`.`ProductID`, `t0`.`OrderID`
+FROM (
+    SELECT `o`.`OrderID`
+    FROM `Orders` AS `o`
+    WHERE `o`.`OrderID` < 10300
+    ORDER BY `o`.`OrderID`
+    LIMIT @__p_0
+) AS `t`
+LEFT JOIN (
+    SELECT `o0`.`ProductID`, `o0`.`OrderID`
+    FROM `Order Details` AS `o0`
+) AS `t0` ON `t`.`OrderID` = `t0`.`OrderID`
+ORDER BY `t`.`OrderID`, `t0`.`ProductID`");
+        }
+
         [SupportedServerVersionCondition(nameof(ServerVersionSupport.WindowFunctions))]
         public override Task SelectMany_Joined_Take(bool async)
         {