Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript fix demo and shadow #19

Merged
merged 2 commits into from
Jul 29, 2019
Merged

Conversation

valdrinkoshi
Copy link
Collaborator

Fixes #18 by looking at the shadowRoot host to retrieve internal state info.
Updates demo to use only Custom Elements V1 and ES modules instead of HTML Imports

@valdrinkoshi valdrinkoshi requested a review from aomarks July 29, 2019 02:48
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@valdrinkoshi valdrinkoshi force-pushed the typescript-fix-demo-and-shadow branch from 5cf0cc3 to 95cb4ee Compare July 29, 2019 02:58
@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@valdrinkoshi valdrinkoshi force-pushed the typescript-fix-demo-and-shadow branch from 95cb4ee to 4ea9bf1 Compare July 29, 2019 03:04
@aomarks
Copy link
Contributor

aomarks commented Jul 29, 2019

Change looks good, but tests are now failing in the same way that I reported in #17 (e.g. https://app.saucelabs.com/tests/0d211355b0754f178a5c5c900c8ac5c3#0) but on other browsers too... it seems like this could be some kind of timeout issue? I did try bumping max-duration in my PR, but it didn't seem to make any difference (I couldn't actually figure out what system reads that parameter).

@aomarks
Copy link
Contributor

aomarks commented Jul 29, 2019

Merging, since the test failures are flakes (note different browsers fail on pr and push, and all the videos show that 100% of tests actually passed).

@aomarks aomarks changed the base branch from typescript to master July 29, 2019 18:19
@aomarks aomarks merged commit 4f6c4e7 into master Jul 29, 2019
@aomarks aomarks deleted the typescript-fix-demo-and-shadow branch July 29, 2019 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

exception thrown when adding new sibling to shadow root
3 participants