Use translateX instead of translate3d #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The tests failed due to a selenium issue. How to trigger them again? |
|
Yeah, Selenium has been flaky recently. I've restarted them a couple times but it keeps failing... Anyways, this change shouldn't have any actual effect (famous last words). Is this a general workaround for the |
|
It solves the |
|
up? |
|
Yeah, seems like this is just a problem with Firefox + our CI setup; we're working on this and it should be fixed soon. Anyways, this is a noop change that makes the code slightly cleaner, so I'll go ahead and merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use translateX instead of translated3d to move the selection bar. This is preferable to avoid some bugs present in Chrome (such as https://bugs.chromium.org/p/chromium/issues/detail?id=449107).