This repository has been archived by the owner on Dec 19, 2024. It is now read-only.
link to simple-overlay example #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valdrinkoshi
force-pushed
the
185-better-docs
branch
from
f81275d to
c0e45fe
Compare
valdrinkoshi
force-pushed
the
185-better-docs
branch
from
c0e45fe to
3b6fc3e
Compare
|
LGTM (maybe squish commits?) |
|
Done, using the new squash feature from github 🎉 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #185, link the
simple-overlayimplementation in the docs, and explain the limitations of focus wrapping that wraps focus within the overlay's light dom.