Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade windows crate #96

Merged
merged 2 commits into from
Dec 2, 2022
Merged

Upgrade windows crate #96

merged 2 commits into from
Dec 2, 2022

Conversation

mauvealerts
Copy link
Contributor

Incompatibilities fixed:

  • optional params are now Rust Option
  • inparams now take a reference

@mauvealerts
Copy link
Contributor Author

mauvealerts commented Dec 1, 2022 •
edited
Loading

Something I forgot to mention: this implicitly increases MSRV from 1.59 (2022-02-24) to 1.64 (2022-09-22)

PolyMeilex
PolyMeilex approved these changes Dec 2, 2022
View reviewed changes
Copy link
Owner

@PolyMeilex PolyMeilex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@PolyMeilex PolyMeilex merged commit 4644229 into PolyMeilex:master Dec 2, 2022
@mauvealerts mauvealerts deleted the bump-ver branch December 2, 2022 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PolyMeilex PolyMeilex PolyMeilex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mauvealerts @PolyMeilex