[Issue-106] Refactor Accuracy Package #147
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r when selector is a suffix of an existing initialisation message and when it is not.
…e and the message returns 'AllTheRest'
…ils when we get PMAccuracy managed by coverall.io
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of #106 I discovered that the
testArgumentAt:was failing because of some magic aroundfindKey. I removed that magic and made things more explicit by extracting code from there into a new methodfindKey:which is more unit testable by taking in the name of the selector. This PR performed the refactoring and replaced invocations of that with the new method.To confirm I haven't introduced new bugs, I used defect injection.