-
-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ability to convert vectors to matrices and vice versa #129
Merged
SergeStinckwich
merged 7 commits into
PolyMathOrg:development
from
nikhilpinnaparaju:development
Jun 5, 2019
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
0315406
Added Basic Scalar subtraction test
nikhilpinnaparaju edf0a44
added test for subtract PMVector from a Number
nikhilpinnaparaju e22d0a4
QuickFix of the scalar subtraction with PMVector Issue
nikhilpinnaparaju ccbe2d5
Added methods for intuitive conversion between vectors and matrices
nikhilpinnaparaju 4335930
Merge 7d2ef9f0eccaeb305e71c5f7c57d4c9fae8613bc
nikhilpinnaparaju 702da9b
Tests for matrix <-> vector interconversions
nikhilpinnaparaju 2d44383
Fixed implementation of reshape
nikhilpinnaparaju File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -122,6 +122,18 @@ PMVector >> asPMVector [ | |
^ self | ||
] | ||
|
||
{ #category : #'as yet unclassified' } | ||
PMVector >> checkDimensionalCompatibility: dimensionArray [ | ||
|prod| | ||
prod := 1. | ||
|
||
dimensionArray do: [ :each | prod := prod * each ]. | ||
|
||
self assert: (self size = prod) description: 'Imcompatible combination of Dimensions provided'. | ||
|
||
^true | ||
] | ||
|
||
{ #category : #comparing } | ||
PMVector >> closeTo: aPMVector [ | ||
"Compare two vectors using the default precision from Float >> #closeTo:." | ||
|
@@ -237,6 +249,17 @@ PMVector >> productWithVector: aVector [ | |
into: [ :sum :each | n := n + 1. (aVector at: n) * each + sum] | ||
] | ||
|
||
{ #category : #'as yet unclassified' } | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should this categorised as 'transformation'? |
||
PMVector >> reshapeWithDimensions: dimensionArray [ | ||
| computedRows rowNum colNum | | ||
self checkDimensionalCompatibility: dimensionArray. | ||
rowNum := dimensionArray at: 1. | ||
colNum := dimensionArray at: 2. | ||
computedRows := ((1 to: rowNum) collect: [ :i | (1 to: colNum) collect: [ :j | self at: (i-1*colNum)+j ] ]). | ||
|
||
^PMMatrix rows: computedRows | ||
] | ||
|
||
{ #category : #operation } | ||
PMVector >> scalarProduct: aVector [ | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is unnecessary as you're not relying on the output in places where you send this message.