Issue 29 - PMVector/PMMatrix >> #dot: does not compute a dot product.

src/Math-Core/PMVector.class.st

@@ -20,7 +20,7 @@ Class {
 	#name : #PMVector,
 	#superclass : #Array,
 	#type : #variable,
-	#category : 'Math-Core'
+	#category : #'Math-Core'
 }
 
 { #category : #'instance creation' }
@@ -167,7 +167,7 @@ PMVector >> cumsum [
 
 ]
 
-{ #category : #operation }
+{ #category : #deprecated }
 PMVector >> dot: aVector [
 "Answers the elementwise product of the receiver with aVector."
 	| answer n |
@@ -182,6 +182,21 @@ PMVector >> dot: aVector [
 
 ]
 
+{ #category : #operation }
+PMVector >> hadamardProduct: aVector [
+	"Answers the elementwise product of the receiver with aVector."
+
+	| answer n |
+	answer := self class new: self size.
+	n := 0.
+	self
+		with: aVector
+		do: [ :a :b | 
+			n := n + 1.
+			answer at: n put: a * b ].
+	^ answer
+]
+
 { #category : #'as yet unclassified' }
 PMVector >> householder [
 	"returns a collection of the skalar beta and the housholder vector"

src/Math-Core/PMWeightedPoint.class.st

@@ -12,7 +12,7 @@ Class {
 		'weight',
 		'error'
 	],
-	#category : 'Math-Core'
+	#category : #'Math-Core'
 }
 
 { #category : #creation }

src/Math-Matrix/PMJacobiTransformationHelper.class.st

@@ -8,7 +8,7 @@ Class {
 		'eigenvalues',
 		'eigenvectors'
 	],
-	#category : 'Math-Matrix'
+	#category : #'Math-Matrix'
 }
 
 { #category : #creation }

src/Math-Matrix/PMLUPDecomposition.class.st

@@ -26,7 +26,7 @@ Class {
 		'permutation',
 		'parity'
 	],
-	#category : 'Math-Matrix'
+	#category : #'Math-Matrix'
 }
 
 { #category : #creation }

src/Math-Matrix/PMLargestEigenValueFinder.class.st

@@ -20,7 +20,7 @@ Class {
 		'eigenvector',
 		'transposeEigenvector'
 	],
-	#category : 'Math-Matrix'
+	#category : #'Math-Matrix'
 }
 
 { #category : #information }

src/Math-Matrix/PMLinearEquationSystem.class.st

@@ -22,7 +22,7 @@ Class {
 		'rows',
 		'solutions'
 	],
-	#category : 'Math-Matrix'
+	#category : #'Math-Matrix'
 }
 
 { #category : #creation }

src/Math-Matrix/PMMatrix.class.st

@@ -15,7 +15,7 @@ Class {
 		'rows',
 		'lupDecomposition'
 	],
-	#category : 'Math-Matrix'
+	#category : #'Math-Matrix'
 }
 
 { #category : #example }
@@ -31,7 +31,7 @@ b := PMMatrix rows: #( ( 1 2 3 ) (-2 1 7)).
 c := a * b.
 
 "Elementwise matrix product"
-d := a dot:b.
+d := a hadamardProduct: b.
 
 "This is how we can create a vector"
 a := #(1 4 9 16 25) asPMVector.
@@ -407,7 +407,7 @@ PMMatrix >> dimension [
 	^ self rows size @ (self rows at: 1) size
 ]
 
-{ #category : #operation }
+{ #category : #deprecated }
 PMMatrix >> dot: aMatrix [
 	"Answers the elementwise product of the receiver with aMatrix."
 	^ aMatrix elementwiseProductWithMatrix: self
@@ -458,6 +458,11 @@ PMMatrix >> flattenRows [
 	^ answer asPMVector
 ]
 
+{ #category : #operation }
+PMMatrix >> hadamardProduct: aMatrix [
+	^ aMatrix  elementwiseProductWithMatrix: self
+]
+
 { #category : #comparing }
 PMMatrix >> hash [
 	^ rows hash

src/Math-Matrix/PMSingularMatrixError.class.st

@@ -5,7 +5,7 @@ some calculations dont work with singular matrices and result eg with errors lik
 Class {
 	#name : #PMSingularMatrixError,
 	#superclass : #ArithmeticError,
-	#category : 'Math-Matrix'
+	#category : #'Math-Matrix'
 }
 
 { #category : #accessing }

src/Math-Matrix/PMSingularValueDecomposition.class.st

@@ -40,7 +40,7 @@ Class {
 		'signU',
 		'signV'
 	],
-	#category : 'Math-Matrix'
+	#category : #'Math-Matrix'
 }
 
 { #category : #'instance creation' }

src/Math-Matrix/PMSymmetricMatrix.class.st

@@ -4,7 +4,7 @@ This class can be instantiated like DhbMatrix via #rows:, but the user has to ma
 Class {
 	#name : #PMSymmetricMatrix,
 	#superclass : #PMMatrix,
-	#category : 'Math-Matrix'
+	#category : #'Math-Matrix'
 }
 
 { #category : #'instance creation' }

src/Math-PrincipalComponentAnalysis/PMSciKitLearnSVDFlipAlgorithm.class.st

@@ -78,10 +78,10 @@ PMSciKitLearnSVDFlipAlgorithm >> signs [
 
 { #category : #accessing }
 PMSciKitLearnSVDFlipAlgorithm >> uFlipped [
-	^ u dot: (self signMatrixForU).
+	^ u hadamardProduct: (self signMatrixForU).
 ]
 
 { #category : #accessing }
 PMSciKitLearnSVDFlipAlgorithm >> vFlipped [
-	^ v dot: (self signMatrixForV) .
+	^ v hadamardProduct: (self signMatrixForV) .
 ]

src/Math-Tests-Core/PMVectorTest.class.st

@@ -164,6 +164,20 @@ PMVectorTest >> testVectorGreater [
 
 ]
 
+{ #category : #tests }
+PMVectorTest >> testVectorHadamardProduct [
+	"Code Example 8.1"
+
+	| u v w |
+	u := #(1 2 3) asPMVector.
+	v := #(3 4 5) asPMVector.
+	w := u hadamardProduct: v.
+	self assert: (w size) equals: 3.
+	self assert: (w at: 1) equals: 3.
+	self assert: (w at: 2) equals: 8.
+	self assert: (w at: 3) equals: 15
+]
+
 { #category : #tests }
 PMVectorTest >> testVectorLess [
 

src/Math-Tests-Matrix/PMAdditionalTest.class.st

@@ -5,7 +5,7 @@ here are tests that would be in Math-Tests-DHB-Numerical, if it could construct
 Class {
 	#name : #PMAdditionalTest,
 	#superclass : #TestCase,
-	#category : 'Math-Tests-Matrix'
+	#category : #'Math-Tests-Matrix'
 }
 
 { #category : #tests }

src/Math-Tests-Matrix/PMMatrixTest.class.st

@@ -1,7 +1,7 @@
 Class {
 	#name : #PMMatrixTest,
 	#superclass : #TestCase,
-	#category : 'Math-Tests-Matrix'
+	#category : #'Math-Tests-Matrix'
 }
 
 { #category : #tests }
@@ -352,6 +352,22 @@ PMMatrixTest >> testMatrixGreater [
 	self assert: ((b rowAt: 2) at: 3) equals: true
 ]
 
+{ #category : #'linear algebra' }
+PMMatrixTest >> testMatrixHadamardProduct [
+	| a b c |
+	a := PMMatrix rows: #(#(1 0 1) #(-1 -2 3)).
+	b := PMMatrix rows: #(#(1 2 3) #(-2 1 7)).
+	c := a hadamardProduct: b.
+	self assert: c numberOfRows equals: 2.
+	self assert: c numberOfColumns equals: 3.
+	self assert: ((c rowAt: 1) at: 1) equals: 1.
+	self assert: ((c rowAt: 1) at: 2) equals: 0.
+	self assert: ((c rowAt: 1) at: 3) equals: 3.
+	self assert: ((c rowAt: 2) at: 1) equals: 2.
+	self assert: ((c rowAt: 2) at: 2) equals: -2.
+	self assert: ((c rowAt: 2) at: 3) equals: 21
+]
+
 { #category : #comparing }
 PMMatrixTest >> testMatrixHash [
 	| a b c |
@@ -428,7 +444,7 @@ PMMatrixTest >> testMatrixMultiplyElementwise [
 	| a b c |
 	a := PMMatrix rows: #(#(1 0 1) #(-1 -2 3)).
 	b := PMMatrix rows: #(#(1 2 3) #(-2 1 7)).
-	c := a dot:b.
+	c := a dot: b.
 	self assert: c numberOfRows equals: 2.
 	self assert: c numberOfColumns equals: 3.
 	self assert: ((c rowAt: 1) at: 1) equals: 1.

src/Math-Tests-Matrix/PMQRTest.class.st

@@ -1,7 +1,7 @@
 Class {
 	#name : #PMQRTest,
 	#superclass : #TestCase,
-	#category : 'Math-Tests-Matrix'
+	#category : #'Math-Tests-Matrix'
 }
 
 { #category : #running }

src/Math-Tests-Matrix/PMRestTest.class.st

@@ -1,7 +1,7 @@
 Class {
 	#name : #PMRestTest,
 	#superclass : #TestCase,
-	#category : 'Math-Tests-Matrix'
+	#category : #'Math-Tests-Matrix'
 }
 
 { #category : #tests }

src/Math-Tests-Matrix/PMSingularValueDecompositionTest.class.st

@@ -35,7 +35,7 @@ Class {
 		'actualV',
 		'actualS'
 	],
-	#category : 'Math-Tests-Matrix'
+	#category : #'Math-Tests-Matrix'
 }
 
 { #category : #'as yet unclassified' }

src/Math-Tests-Matrix/PMSymmetricMatrixTest.class.st

@@ -1,7 +1,7 @@
 Class {
 	#name : #PMSymmetricMatrixTest,
 	#superclass : #TestCase,
-	#category : 'Math-Tests-Matrix'
+	#category : #'Math-Tests-Matrix'
 }
 
 { #category : #tests }