fix(environments): buildah cannot find base images. #548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boehmseb
reviewed
Mar 7, 2023
| @@ -400,7 +400,7 @@ def _create(self, tag: str, from_: model.FromLayer) -> model.MaybeContainer: | |||
| image = model.Image(tag, from_, []) | |||
|
|
|||
| # container_id, err = run(bb_buildah('from')[from_.base]) | |||
| res = run(bb_buildah('from')[from_.base]) | |||
| res = run(bb_buildah('from')[from_.base.lower()]) | |||
There was a problem hiding this comment.
Wouldn't it make sense to use the existing conversion function oci_compliant_name() from commands.py?
I can't say for sure whether this is the correct location to apply this transformation since I don't know whether this is the only location where FromLayers are handled.
My first idea would have been to use a converter in the FromLayer class as is done with the commands, i.e.,
class FromLayer(Layer):
base: str = attr.ib(converter=oci_compliant_name)
There was a problem hiding this comment.
You are right. For this I just used the same behavior as in other locations in the same module. Using oci_compliant_name is the sane way to go.
|
@simbuerg this should be ready to merge, right? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe this fixes #544