feat(source): introduce type skeleton and prototypes for context-awar… #510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e version enumeration. This introduces a (currently) non-working stage of context-aware version enumeration. The main idea will be a 2-phase design for version enumeration: * Phase 1: Enumerate all context-free sources, i.e., sources that do not need to know anything about the context they are being enumerated in. * Phase 2: Iterate over all versions from Phase 1 and feed each resulting variant context into all context-sensitive sources. These may provide a new list of versions for each context they are given. The resulting list of variant context objects will be iterated on by benchbuild just as before. Integration for CLI is pending. In essence, all sampling and filtering should be possible on the new enumeration just as before.
Use from benchbuild import source, instead of directly accessing source.base.
Codecov ReportBase: 50.74% // Head: 52.23% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #510 +/- ##
==========================================
+ Coverage 50.74% 52.23% +1.49%
==========================================
Files 124 124
Lines 8207 8304 +97
Branches 1274 1025 -249
==========================================
+ Hits 4165 4338 +173
+ Misses 3882 3789 -93
- Partials 160 177 +17
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Not supported in python 3.7
vulder
approved these changes
Nov 2, 2022
This fixes #514 until a permanent upgrade path can be created.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e version enumeration.
This introduces a (currently) non-working stage of context-aware version enumeration.
The main idea will be a 2-phase design for version enumeration:
Phase 1: Enumerate all context-free sources, i.e., sources that do not need to know anything about the context they are being enumerated in.
Phase 2: Iterate over all versions from Phase 1 and feed each resulting variant context into all context-sensitive sources. These may provide a new list of versions for each context they are given.
The resulting list of variant context objects will be iterated on by benchbuild just as before.
Integration for CLI is pending. In essence, all sampling and filtering should be possible on the new enumeration just as before.