-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[main] Next release changes #162
Changes from 88 commits
3bc0ac5
208527a
7a2833c
8a3c9ce
00a5649
f8e3ddc
9675745
bd821bf
a169c0a
deb78d1
fa4bdbb
73f8484
e7c80d2
f299bdc
1deb724
02f4614
0f58daf
a8830c0
68cab6d
3fb4dc4
dfcc2d0
a35c6bd
08a42dd
4e4c109
f2fa7d0
83ed01a
42fd0bf
2116f6e
10a8fca
d87dfb4
269a8ae
55e7663
b8fa9e2
4d311ff
1b112bf
f01fb77
9020445
4732981
a646578
0116c14
329ba27
004f182
a1f2a5d
3e37991
f552103
819e277
6eb6991
f5dd0ae
b07364a
f1238de
dd3ce84
9c0a4b8
f65b345
7b1cf8f
13caeee
6cb3019
b5f6adc
4eca917
36647eb
e8c16a7
2fc4a6a
fb0a04e
1e51108
527e275
0d2deaa
17c2145
e7608dc
5f14f78
866e630
bbf6c15
0d30a6f
96506ed
90157f5
e83991a
09d9648
1eec461
b779af4
058c41b
a7669b1
6a2c482
b75d6e6
82b4884
570113e
b984b1b
312b19e
c82f5e0
27ca0a7
21871f6
edf3e5a
67fec69
fb75890
e14ea9c
0068699
0f0321d
a7895b4
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -77,7 +77,8 @@ jobs: | |
with: | ||
name: Rolling release | ||
body: Rolling release built from latest commit on `main` branch. | ||
tag_name: rolling-release | ||
tag_name: 'rolling_release' | ||
make_latest: true | ||
files: | | ||
./output/N64FlashcartMenu.n64 | ||
./output/menu.bin | ||
|
@@ -90,9 +91,10 @@ jobs: | |
uses: softprops/action-gh-release@v2 | ||
if: github.ref == 'refs/heads/develop' | ||
with: | ||
name: 'Rolling dev release-V${{ github.run_id }}' | ||
body: Rolling dev prerelease built from latest commit on `develop` branch. | ||
tag_name: prerelease-dev | ||
name: 'Rolling pre-release' | ||
body: Experimental pre-release built from latest commit on `develop` branch. | ||
target_commitish: develop | ||
tag_name: 'rolling_pre-release' | ||
prerelease: true | ||
files: | | ||
./output/N64FlashcartMenu.n64 | ||
|
@@ -111,7 +113,7 @@ jobs: | |
- uses: actions/checkout@v4 | ||
|
||
- name: Run Doxygen | ||
uses: mattnotmitt/doxygen-action@1.9.5 | ||
uses: mattnotmitt/doxygen-action@v1 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 💡 Codebase verification Moving to v1 tag is not recommended - use specific version instead The change from
Recommend using a specific version like uses: mattnotmitt/[email protected] 🔗 Analysis chainVerify Doxygen action version compatibility Switching from specific version Let me gather more information about the Doxygen configuration and usage in the repository. Let me check the workflow file specifically to understand how Doxygen is being used. Let me check the developer guide to understand if there are any specific Doxygen requirements or configurations that need to be maintained. 🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Check if we have any custom Doxygen configurations that might be affected
rg -A 5 "DOXYGEN" Doxyfile
rg -A 5 "DOXYGEN" .github/workflows/build.yml
# Get the action's latest changes
gh api repos/mattnotmitt/doxygen-action/releases/latest
Length of output: 1922 Script: #!/bin/bash
# Check for Doxyfile and any custom configurations
fd Doxyfile --exec cat {}
# Check for any Doxygen-related files or configurations
fd -e doxyfile -e Doxyfile -e doxy --exec-batch echo "=== {} ===" \; cat {}
# Look for Doxygen-specific settings in workflow files
rg -l "doxyfile|doxygen" .github/workflows/
Length of output: 122126 Script: #!/bin/bash
# Check the workflow file for Doxygen usage context
cat .github/workflows/build.yml
# Look for any additional Doxygen-related files
fd -t f -e md -e txt -e rst -e html -e yml -e yaml | xargs rg -l "doxygen|Doxygen"
Length of output: 3788 Script: #!/bin/bash
# Check developer guide for Doxygen-related content
cat docs/99_developer_guide.md
# Check latest version and changes in the Doxygen action
gh api repos/mattnotmitt/doxygen-action/releases --jq '.[0,1,2] | {tag_name, body}'
Length of output: 3511 |
||
with: | ||
doxyfile-path: './Doxyfile' | ||
|
||
|
Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
@@ -18,18 +18,21 @@ An open source menu for N64 flashcarts. | |||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
* Fully Open Source. | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
* Loads all known N64 games (including iQue and Aleck64 ROMs (even if they are byteswapped)). | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
* Fully emulates the 64DD and loads 64DD disks (SummerCart64 only). | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
* Emulator support (NES, SNES, GB, GBC) ROMs. | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
* Emulator support (NES, SNES, GB, GBC, SMS, GG, CHF) ROMs. | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
* N64 ROM box image support. | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
* Background image (PNG) support. | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
* Comprehensive ROM save database (including HomeBrew headers). | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
* Comprehensive ROM information display. | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
* Real Time Clock support. | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
* Music playback (MP3). | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
* Menu sound effects. | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
* N64 ROM autoload. | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
## Documentation | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
* [Getting started guide](./docs/00_getting_started_sd.md) | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
* [Menu controls](./docs/01_menu_controls.md) | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
* [Menu customizations](./docs/07_menu_customizations.md) | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 💡 Codebase verification Broken documentation link detected The link to the menu customizations documentation (
🔗 Analysis chainVerify the menu customizations documentation link The link format is consistent with other documentation links. 🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Verify that the linked documentation file exists
test -f docs/07_menu_customizations.md && echo "Documentation file exists" || echo "Documentation file missing"
Length of output: 103 |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
* [Developer guide](./docs/99_developer_guide.md) | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
## Video showcase (as of Oct 12 2023) | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
@@ -48,12 +51,51 @@ An open source menu for N64 flashcarts. | |||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
## Experimental features | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
These features are subject to change: | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
### ROM Boxart | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
To use boxart, you need to place png files of size 158x112 in the folder `/menu/boxart` on the SD card. | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Each file must be named according to the 2 letter ROM ID, or 3 letter ROM ID including media type. | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
i.e. for GoldenEye 2 letters, this would be `GE.png`. | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
i.e. for GoldenEye 3 letters, this would be `NGE.png`. | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
A known set of PNG files using 2 letter ID's can be downloaded [here](https://mega.nz/file/6cNGwSqI#8X5ukb65n3YMlGaUtSOGXkKo9HxVnnMOgqn94Epcr7w). | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
### N64 ROM autoload | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
To use the autoload function, while on the `N64 ROM information` display, press the `R` button on your joypad and select the `Set ROM to autoload` option. When you restart the console, it will now only load the selected ROM rather than the menu. | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
NOTE: to return to the menu, hold joypad `start` button whilst powering on the console. | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
### GamePak sprites | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
To use N64 `GamePak` sprites, place `PNG` files within the `sd:/menu/boxart/` folder. | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
#### Supported sprites | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
These must be `PNG` files that use the following dimensions: | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
* Standard N64 GamePak boxart sprites: 158x112 | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
* Japanese N64 GamePak boxart sprites: 112x158 | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
* 64DD boxart sprites: 129x112 | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
They will be loaded by directories using each character (case-sensitive) of the full 4 character Game Code (as identified in the menu ROM information). | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
i.e. for GoldenEye NTSC USA (NGEE), this would be `sd:/menu/boxart/N/G/E/E/boxart_front.png`. | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
i.e. for GoldenEye PAL (NGEP), this would be `sd:/menu/boxart/N/G/E/P/boxart_front.png`. | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
To improve compatibility between regions (as a fallback), you may exclude the region ID (last matched directory) for GamePaks to match with 3 letter IDs instead: | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
i.e. for GoldenEye, this would be `sd:/menu/boxart/N/G/E/boxart_front.png`. | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
**Note1:** Excluding the region ID may show the wrong boxart. | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
**Note2:** For future support, boxart sprites should also include: `boxart_back.png`, `boxart_top.png`, `boxart_bottom.png`, `boxart_left.png`, `boxart_right.png`. | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
As a starting point, here is a link to a boxart pack following the new structure, including `boxart_front.png` and failback images: | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
* [Link](https://drive.google.com/file/d/1IpCmFqmGgGwKKmlRBxYObfFR9XywaC6n/view?usp=drive_link) | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
#### Compatibilty mode | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
If you cannot yet satisfy the correct boxart layout, The menu still has **deprecated** support for filenames containing the Game ID. | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
**Note:** This will add a noticeable delay for displaying parts of the menu. | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Each file must be named according to the 2,3 or 4 letter GamePak ID (matched in this order). | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
i.e. | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
* for GoldenEye 4 letters, this would be `sd:/menu/boxart/NGEE.png` and/or `sd:/menu/boxart/NGEP.png`. | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
* for GoldenEye 3 letters, this would be `sd:/menu/boxart/NGE.png`. | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
* for GoldenEye 2 letters, this would be `sd:/menu/boxart/GE.png`. | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
As a starting point, here are some links to boxart packs: | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
* [Japan Boxart](https://mega.nz/file/KyJR0B6B#ERabLautAVPaqJTIdBSv4ghbudNhK7hnEr2ZS1Q6ub0) | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
* [American Boxart](https://mega.nz/file/rugAFYSQ#JHfgCU2amzNVpC4S6enP3vg--wtAAwsziKa7cej6QCc) | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
* [European Boxart](https://mega.nz/file/OmIV3aAK#kOWdutK1_41ffN64R6thbU7HEPR_M9qO0YM2mNG6RbQ) | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
* [64DD Boxart](https://mega.nz/file/ay5wQIxJ#k3PF-VMLrZJxJTr-BOaOKa2TBIK7c2t4zwbdshsQl40) | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
### Menu Settings | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
@@ -73,15 +115,32 @@ If required, you can manually adjust the file on the SD card using your computer | |||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
* Download the latest `menu.bin` file from the [releases](https://github.com/Polprzewodnikowy/N64FlashcartMenu/releases/) page, then put it in the root directory of your SD card. | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
### ED64 & ED64P | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
### ED64 - WIP - UNTESTED AND UNSUPPORTED - USE AT OWN RISK | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Currently not supported, but work is in progress (See [PR's](https://github.com/Polprzewodnikowy/N64FlashcartMenu/pulls)). | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
NOTE: The menu may be able to load ROM's but not perform saves and may break existing ones.. | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
The aim is to replace [Altra64](https://github.com/networkfusion/altra64) and [ED64-UnofficialOS](https://github.com/n64-tools/ED64-UnofficialOS-binaries). | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
#### ED64 (Vseries) | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
The aim is to reach feature parity with [ED64-UnofficialOS](https://github.com/n64-tools/ED64-UnofficialOS-binaries) / [ED64-OfficialOS](https://krikzz.com/pub/support/everdrive-64/v2x-v3x/os-bin/). | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Download the `OS64.v64` ROM from the latest [action run - assets] and place it in the `/ED64` folder. | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
#### ED64 (X series) | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
X Series support is currently awaiting fixes, in the meantime use the official [OS](https://krikzz.com/pub/support/everdrive-64/x-series/OS/) instead. | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
#### ED64 (P clone) | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Download the `OS64P.v64` ROM from the latest [action run - assets] and place it in the `/ED64P` folder. | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
The aim is to reach feature parity with [Altra64](https://github.com/networkfusion/altra64) | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🛠️ Refactor suggestion Fix grammatical issues and improve clarity
### ED64 - WIP - UNTESTED AND UNSUPPORTED - USE AT OWN RISK
Currently not supported, but work is in progress (See [PR's](https://github.com/Polprzewodnikowy/N64FlashcartMenu/pulls)).
-NOTE: The menu may be able to load ROM's but not perform saves and may break existing ones..
+> **Warning**: While the menu may be able to load ROMs, save functionality is not guaranteed and existing saves may be corrupted.
#### ED64 (Vseries)
The aim is to reach feature parity with [ED64-UnofficialOS](https://github.com/n64-tools/ED64-UnofficialOS-binaries) / [ED64-OfficialOS](https://krikzz.com/pub/support/everdrive-64/v2x-v3x/os-bin/).
Download the `OS64.v64` ROM from the latest [action run - assets] and place it in the `/ED64` folder.
#### ED64 (X series)
-X Series support is currently awaiting fixes, in the meantime use the official [OS](https://krikzz.com/pub/support/everdrive-64/x-series/OS/) instead.
+X Series support is currently awaiting fixes. Please use the official [OS](https://krikzz.com/pub/support/everdrive-64/x-series/OS/) for now. 📝 Committable suggestion
Suggested change
🧰 Tools🪛 LanguageTool[typographical] ~120-~120: Two consecutive dots (DOUBLE_PUNCTUATION) [style] ~127-~127: ‘in the meantime’ might be wordy. Consider a shorter alternative. (EN_WORDINESS_PREMIUM_IN_THE_MEANTIME) |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
# Open source software and licenses used | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
* [libdragon](https://github.com/DragonMinded/libdragon) (UNLICENSE License) | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
* [libspng](https://github.com/randy408/libspng) (BSD 2-Clause License) | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
* [mini.c](https://github.com/univrsal/mini.c) (BSD 2-Clause License) | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
* [minimp3](https://github.com/lieff/minimp3) (CC0 1.0 Universal) | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
* [miniz](https://github.com/richgel999/miniz) (MIT License) | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
## Sounds | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
See [License](https://pixabay.com/en/service/license-summary/) for the following sounds: | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
* [Cursor sound](https://pixabay.com/en/sound-effects/click-buttons-ui-menu-sounds-effects-button-7-203601/) by Skyscraper_seven (Free to use) | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
* [Actions (Enter, back) sound](https://pixabay.com/en/sound-effects/menu-button-user-interface-pack-190041/) by Liecio (Free to use) | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
* [Error sound](https://pixabay.com/en/sound-effects/error-call-to-attention-129258/) by Universfield (Free to use) |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
# Menu customization | ||
|
||
## Using a custom font | ||
Add a `font64` file to the root directory called "custom.font64" | ||
This can be build using `libdragon` tools. |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -45,10 +45,13 @@ For ease of development and debugging, the menu ROM can run in the [Ares emulato | |
* Add the required file to the correct folder on your SD card. | ||
|
||
|
||
## Update Libdragon submodule | ||
This repo currently uses the `preview` branch as a submodule at a specific commit. | ||
## Update submodules | ||
To update to the latest version, use `git submodule update --remote` from the terminal. | ||
|
||
### libdragon | ||
This repo currently uses the `preview` branch as a submodule at a specific commit. | ||
* To ensure your local instance is building against it, use `cd ./libdragon && make clobber -j && make libdragon tools -j && make install tools-install -j && cd ..` | ||
Comment on lines
+48
to
+53
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🛠️ Refactor suggestion Enhance submodule update instructions for clarity and safety The current instructions for updating submodules could be improved to prevent potential issues:
Consider this revision: ## Update submodules
-To update to the latest version, use `git submodule update --remote` from the terminal.
+### Updating specific submodules
+
+> ⚠️ **Warning**: Updating submodules may introduce breaking changes. Review the changelog of each submodule before updating.
+
+To update specific submodules:
+```bash
+# Update libdragon to latest version
+git submodule update --remote libdragon
+```
+
+After updating, commit the changes:
+```bash
+git add libdragon
+git commit -m "chore: update libdragon submodule"
+```
### libdragon
This repo currently uses the `preview` branch as a submodule at a specific commit.
-* To ensure your local instance is building against it, use `cd ./libdragon && make clobber -j && make libdragon tools -j && make install tools-install -j && cd ..`
+* To ensure your local instance is building against it:
+```bash
+cd ./libdragon
+make clobber -j
+make libdragon tools -j
+make install tools-install -j
+cd ..
+``` |
||
|
||
## Generate documentation | ||
Run `doxygen` from the dev container terminal. | ||
Make sure you fix the warnings before creating a PR! | ||
|
@@ -57,6 +60,8 @@ Generated documentation is located in the `output/docs` folder and auto-publishe | |
Once merged, they can be viewed [here](https://polprzewodnikowy.github.io/N64FlashcartMenu/) | ||
|
||
### Test generated docs in the dev-container | ||
Testing the documentation locally allows you to preview changes and ensure everything renders correctly before submitting your changes. | ||
|
||
Comment on lines
+63
to
+64
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🛠️ Refactor suggestion Enhance local documentation testing instructions The instructions for testing documentation locally could be more comprehensive:
Consider this revision: Testing the documentation locally allows you to preview changes and ensure everything renders correctly before submitting your changes.
-Install Prerequisites:
-```bash
-apt-get install ruby-full build-essential zlib1g-dev
-gem install jekyll bundler
-```
+### Install Prerequisites
+
+#### On Debian/Ubuntu:
+```bash
+sudo apt-get install ruby-full build-essential zlib1g-dev
+```
+
+#### On macOS with Homebrew:
+```bash
+brew install ruby
+```
+
+#### On Windows:
+Download and install Ruby from https://rubyinstaller.org/
+
+### Install Jekyll
+```bash
+# You might need sudo/admin privileges
+gem install jekyll bundler
+```
+
+### Serve Documentation
+```bash
+cd output/docs
+jekyll serve
+```
+
+The documentation will be available at http://localhost:4000
+
+To stop the server, press `Ctrl+C` in the terminal. |
||
Install Prerequisites: | ||
```bash | ||
apt-get install ruby-full build-essential zlib1g-dev | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codebase verification
Breaking change: Rolling release tag name requires migration plan
The change from
rolling-release
torolling_release
will break existing integrations as there is an active release using the old tag format (rolling-release
). This requires:🔗 Analysis chain
Verify impact of rolling release tag name change
The change from
rolling-release
torolling_release
and addition ofmake_latest: true
could affect existing automation or documentation.Consider:
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
Length of output: 252
Script:
Length of output: 216