Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ability to set SFX audio without console reboot #118

Merged
merged 7 commits into from
Jul 17, 2024
Merged

Fix ability to set SFX audio without console reboot #118

merged 7 commits into from
Jul 17, 2024

Conversation

networkfusion
Copy link
Collaborator

Description

Allow realtime setting changes in menu.

Motivation and Context

The setting previously required a flashcart reboot.

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that adds a new feature)
  • Bug fix (fixes an issue)
  • Breaking change (breaking change)
  • Config and build (change in the configuration and build system, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: GITHUB_USER <GITHUB_USER_EMAIL>

@networkfusion
Fix SFX audio
428f27a 
Realtime setting changes in menu.
@networkfusion networkfusion added the enhancement New feature or request label Jul 7, 2024
@networkfusion networkfusion changed the title Fix SFX audio Fix ability to set SFX audio without console reboot Jul 9, 2024
@networkfusion networkfusion merged commit 1deb724 into Polprzewodnikowy:develop Jul 17, 2024
2 checks passed
@networkfusion networkfusion deleted the fix-fgm branch July 17, 2024 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Polprzewodnikowy Polprzewodnikowy Awaiting requested review from Polprzewodnikowy

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@networkfusion