Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sound effects #89

Open
Polprzewodnikowy opened this issue Jan 17, 2024 · 2 comments
Open

Add sound effects #89

Polprzewodnikowy opened this issue Jan 17, 2024 · 2 comments
Labels
enhancement New feature or request merged to develop branch Fixed in the development branch

Comments

@Polprzewodnikowy
Copy link
Owner

Polprzewodnikowy commented Jan 17, 2024

Description

It's a little boring scrolling through files in complete silence, let's add some sound effects in response to button presses.

How to solve the problem

  • find (or make) sound effects, permissible license is a must
  • use libdragon tooling to embed sounds in the final ROM
  • use libdragon API to load and play sound effects

Describe alternatives you've considered

No response

Additional context

No response

@Polprzewodnikowy Polprzewodnikowy added enhancement New feature or request help wanted Extra attention is needed labels Jan 17, 2024
@networkfusion
Copy link
Collaborator

@networkfusion
Copy link
Collaborator

Perhaps someone wants to go through a website like this one: https://pixabay.com/sound-effects/search/button/ (given the license for them seem sensible (i.e. we can use them without attribution)) and compile a list good and related effects that can be used.

@Suprapote Suprapote mentioned this issue May 25, 2024
9 tasks
@networkfusion networkfusion removed the help wanted Extra attention is needed label Jun 5, 2024
Polprzewodnikowy pushed a commit that referenced this issue Jun 5, 2024
<!--- Provide a general summary of your changes in the Title above -->



## Description
<!--- Describe your changes in detail -->

Adding sound for make the navigation not so borring.

## Motivation and Context
<!--- What does this sample do? What problem does it solve? -->
<!--- If it fixes/closes/resolves an open issue, please link to the
issue here -->

This
[issue](#89)

## How Has This Been Tested?
<!-- (if applicable) -->
<!--- Please describe in detail how you tested your sample/changes. -->
<!--- Include details of your testing environment, and the tests you ran
to -->
<!--- see how your change affects other areas of the code, etc. -->

## Screenshots
<!-- (if appropriate): -->



https://github.com/Polprzewodnikowy/N64FlashcartMenu/assets/111246491/0f8086f6-16b3-4adb-a925-afbfc9fa6ba9


## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all
the boxes that apply: -->
- [x] Improvement (non-breaking change that adds a new feature)
- [ ] Bug fix (fixes an issue)
- [ ] Breaking change (breaking change)
- [ ] Config and build (change in the configuration and build system,
has no impact on code or features)

## Checklist:
<!--- Go over all the following points, and put an `x` in all the boxes
that apply. -->
<!--- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
- [x] My code follows the code style of this project.
- [ ] My change requires a change to the documentation.
- [ ] I have updated the documentation accordingly.
- [ ] I have added tests to cover my changes.
- [ ] All new and existing tests passed.

<!--- It would be nice if you could sign off your contribution by
replacing the name with your GitHub user name and GitHub email contact.
-->
Signed-off-by: GITHUB_USER <GITHUB_USER_EMAIL>

---------

Co-authored-by: Robin Jones <[email protected]>
@networkfusion networkfusion added merged to develop branch Fixed in the development branch labels Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request merged to develop branch Fixed in the development branch
Projects
None yet
Development

No branches or pull requests

2 participants