Fix simulation to allow a dict for dataset #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes 53 in the example from index.ipnyb we use dataset as a dict for household cacluations. In the code we were failing to correctly handle this case. This happening, in part, because the type hint was wrong, but since most of the type hints are wrong I'm fixing the bug first and will come back to address the type hints.
mikesmit
force-pushed
the
53_household_example_broken
branch
from
999a4a7 to
d96b2db
Compare
nikhilwoodruff
approved these changes
Dec 6, 2024
There was a problem hiding this comment.
Thanks- I filed #57 since I think we're missing the GH action that runs make changelog automatically. But I ran it locally here and committed the result.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #53
in the example from index.ipnyb we use dataset as a dict for household cacluations.
In the code we were failing to correctly handle this case.
This happening, in part, because the type hint was wrong, but since most of the type hints are wrong I'm fixing the bug first and will come back to address the type hints.