-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove CBO elasticities toggle #5347
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5347 +/- ##
==========================================
- Coverage 99.12% 99.03% -0.10%
==========================================
Files 2592 2628 +36
Lines 37707 38223 +516
Branches 162 165 +3
==========================================
+ Hits 37378 37854 +476
- Misses 297 335 +38
- Partials 32 34 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also add unit tests while here to appease the codecov?
policyengine_us/variables/gov/simulation/labor_supply_response/labor_supply_response.py
Outdated
Show resolved
Hide resolved
Friendly ping |
Me and @PavelMakarchuk were working through issues with how to write the unit tests for |
@MaxGhenis Yes I would file a separate issue to add testing for labor supply related variables as we can't seem to accommodate the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please fix the unit of the elasticities per my previous comment
Responses should stay USD, elasticities are /1 |
Fixes #5310