Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arizona one time Families Tax rebate #4633

Open
wants to merge 24 commits into
base: master
Choose a base branch
from
Open

Arizona one time Families Tax rebate #4633

wants to merge 24 commits into from

Conversation

yy3187
Copy link
Collaborator

@yy3187 yy3187 commented Jun 11, 2024

fix #4580

PavelMakarchuk
PavelMakarchuk requested changes Jun 11, 2024
View reviewed changes
changelog_entry.yaml Outdated Show resolved Hide resolved
policyengine_us/parameters/gov/states/az/tax/income/rebates/age_threshold.yaml Outdated Show resolved Hide resolved
policyengine_us/parameters/gov/states/az/tax/income/rebates/cap_amount.yaml Outdated Show resolved Hide resolved
policyengine_us/parameters/gov/states/az/tax/income/rebates/cap_amount.yaml Outdated Show resolved Hide resolved
policyengine_us/parameters/gov/states/az/tax/income/rebates/cap_amount.yaml Outdated Show resolved Hide resolved
policyengine_us/parameters/gov/states/az/tax/income/rebates/cap_quantity.yaml Outdated Show resolved Hide resolved
policyengine_us/parameters/gov/states/az/tax/income/rebates/cap_quantity.yaml Outdated Show resolved Hide resolved
policyengine_us/parameters/gov/states/az/tax/income/rebates/younger_amount.yaml Outdated Show resolved Hide resolved
policyengine_us/variables/gov/states/az/tax/income/rebates/az_income_tax_rebates_eligibility.py Outdated Show resolved Hide resolved
policyengine_us/variables/gov/states/az/tax/income/rebates/az_income_tax_rebates_eligibility.py Show resolved Hide resolved
@yy3187 yy3187 requested a review from PavelMakarchuk June 18, 2024 08:48
@yy3187 yy3187 requested a review from PavelMakarchuk June 18, 2024 15:36
@yy3187 yy3187 requested a review from PavelMakarchuk June 20, 2024 07:33
MaxGhenis
MaxGhenis requested changes Jun 20, 2024
View reviewed changes
Copy link
Contributor

@MaxGhenis MaxGhenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it in the legal code?

@PavelMakarchuk
Copy link
Collaborator

@yy3187 please add the relevant bill and the legal code section which is amended - add a comment if the changes are not reflected yet

PavelMakarchuk
PavelMakarchuk reviewed Jun 27, 2024
View reviewed changes
policyengine_us/parameters/gov/states/az/tax/income/rebates/amount.yaml Outdated
reference:
- title: Arizona Families Tax Rebate
href: https://211arizona.org/wp-content/uploads/2023/11/Arizona-Families-Tax-Rebate.pdf#page=1
- title: Arizona SENATE BILL 1734, section 3
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you find the legal code section that was amended?

@yy3187 yy3187 requested a review from PavelMakarchuk July 15, 2024 15:07
PavelMakarchuk
PavelMakarchuk reviewed Jul 15, 2024
View reviewed changes
policyengine_us/parameters/gov/states/az/tax/income/rebates/amount.yaml Outdated
href: https://211arizona.org/wp-content/uploads/2023/11/Arizona-Families-Tax-Rebate.pdf#page=1
- title: Arizona SENATE BILL 1734, Section 3(A)
href: https://www.azleg.gov/legtext/56leg/1R/bills/SB1734S.pdf#page=3
- title: ARIZONA STATE SENATE Fifty-Sixth Legislature, First Regular Session
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from this reference I see:
between October 15, 2023, and November 15, 2023
For the dates when the amount is paid out,

And the age requirement applies in 2021 so we need to check for the age in 2021 (depending on whether it applies just in 2023 or also in following years we could reduce the age by 2 and exclude children under 2)

@yy3187 yy3187 requested a review from PavelMakarchuk July 16, 2024 16:21
@codecov Codecov
Copy link

codecov bot commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.98%. Comparing base (4cb3009) to head (bde746c).
Report is 2 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #4633   +/-   ##
=======================================
  Coverage   98.98%   98.98%           
=======================================
  Files        2492     2494    +2     
  Lines       36228    36262   +34     
  Branches      189      189           
=======================================
+ Hits        35859    35893   +34     
  Misses        339      339           
  Partials       30       30

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yy3187 yy3187 requested a review from PavelMakarchuk July 23, 2024 14:19
@yy3187 yy3187 requested a review from PavelMakarchuk July 29, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxGhenis MaxGhenis MaxGhenis requested changes

@PavelMakarchuk PavelMakarchuk Awaiting requested review from PavelMakarchuk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Arizona one time Families Tax rebate
3 participants
@yy3187 @PavelMakarchuk @MaxGhenis