Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

San Francisco Working Families Tax Credit #4610

Merged
merged 17 commits into from
Jun 14, 2024
Merged

San Francisco Working Families Tax Credit #4610

merged 17 commits into from
Jun 14, 2024

Conversation

xianxinzhu
Copy link
Collaborator

Fixes #4578

PavelMakarchuk
PavelMakarchuk requested changes Jun 7, 2024
View reviewed changes
changelog_entry.yaml Outdated Show resolved Hide resolved
policyengine_us/parameters/gov/states/ca/tax/income/credits/wftc/amount.yaml Outdated Show resolved Hide resolved
...ne_us/variables/gov/states/mt/tax/income/deductions/itemized/mt_medical_expense_deduction.py Outdated Show resolved Hide resolved
policyengine_us/variables/gov/states/ca/tax/income/credits/wftc/ca_wftc.py Outdated Show resolved Hide resolved
policyengine_us/variables/gov/states/ca/tax/income/credits/wftc/ca_wftc.py Outdated Show resolved Hide resolved
...riables/gov/states/ca/tax/income/credits/earned_income/ca_is_qualifying_child_for_caleitc.py Outdated Show resolved Hide resolved
policyengine_us/parameters/gov/states/ca/tax/income/credits/wftc/amount.yaml Outdated Show resolved Hide resolved
PavelMakarchuk
PavelMakarchuk approved these changes Jun 13, 2024
View reviewed changes
Copy link
Collaborator

@PavelMakarchuk PavelMakarchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good besides minor formatting comments

@PavelMakarchuk PavelMakarchuk marked this pull request as ready for review June 13, 2024 16:58
@PavelMakarchuk PavelMakarchuk requested a review from MaxGhenis June 13, 2024 16:58
MaxGhenis
MaxGhenis requested changes Jun 13, 2024
View reviewed changes
Copy link
Contributor

@MaxGhenis MaxGhenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add the 2023 tax year reference, both to the parameter and variable

@MaxGhenis MaxGhenis merged commit d69edd6 into PolicyEngine:master Jun 14, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxGhenis MaxGhenis MaxGhenis approved these changes

@PavelMakarchuk PavelMakarchuk Awaiting requested review from PavelMakarchuk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

San Francisco local EITC - Working Families Tax Credit
3 participants
@xianxinzhu @MaxGhenis @PavelMakarchuk