Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vermont Elderly or Permanently Totally Disabled Tax Credit #3282

Merged
merged 16 commits into from
Nov 27, 2023

Conversation

Shinuing
Copy link
Collaborator

@Shinuing Shinuing commented Nov 19, 2023

Fixes #3281

🤖[deprecated] Generated by Copilot at e42ed69

Summary

🆕📝🔧

This pull request adds the Vermont elderly or disabled tax credit feature to the policy engine, along with a test case and a changelog entry. It also resolves merge conflicts in the Utah retirement credit test file.

We are the coders of the tax reform
We add the features that the people demand
We write the parameters, variables, and tests
We fix the conflicts with our metal skills

Walkthrough

  • Add Vermont elderly or disabled tax credit feature (link, link, link, link, link, link)
  • Remove merge conflict markers from ut_retirement_credit_max.yaml test case file (link, link)

…oss_income/subtractions/elderly_or_disabled/vt_elderly_or_disabled_credit.py
@PavelMakarchuk PavelMakarchuk requested review from MaxGhenis and removed request for MaxGhenis November 27, 2023 17:46
@PavelMakarchuk PavelMakarchuk marked this pull request as ready for review November 27, 2023 17:52
Copy link

codecov bot commented Nov 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (865c3cd) 99.04% compared to head (3ac183b) 99.04%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3282   +/-   ##
=======================================
  Coverage   99.04%   99.04%           
=======================================
  Files        1854     1855    +1     
  Lines       27299    27313   +14     
  Branches      159      159           
=======================================
+ Hits        27038    27052   +14     
  Misses        224      224           
  Partials       37       37           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Shinuing Shinuing requested a review from MaxGhenis November 27, 2023 20:52
Copy link
Contributor

@MaxGhenis MaxGhenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to merge after this nit for readability

@MaxGhenis MaxGhenis merged commit aac5215 into PolicyEngine:master Nov 27, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vermont Elderly or Permanently Totally Disabled Tax Credit
3 participants