Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate Ohio income tax parameter name deductions #3271

Merged
merged 2 commits into from
Nov 15, 2023

Conversation

PavelMakarchuk
Copy link
Collaborator

@PavelMakarchuk PavelMakarchuk commented Nov 15, 2023

Fixes #3270

🤖[deprecated] Generated by Copilot at 867a796

Summary

🐛📝🎨

This pull request fixes various issues with the state income tax calculations for Ohio and Kentucky, by deleting a duplicated parameter, updating the sources and values of deductions, and correcting the syntax and references of the variables.

oh_deductions
Fixing bugs for Ohio
Autumn tax season

Walkthrough

  • Fix a bug with Ohio income tax parameter name deductions, which was duplicated in the original code (link, link)
  • Update the list of deductions that Ohio allows from the federal adjusted gross income, based on the latest tax forms and instructions, and delete the unused file policyengine_us/parameters/gov/states/oh/tax/income/deductions.yaml (link, link)
  • Add a comma at the end of the reference tuple in the ky_filing_status class, to follow the Python style guide and avoid a syntax error (link)

Copy link

codecov bot commented Nov 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (631134a) 99.02% compared to head (b4d4e30) 99.02%.
Report is 15 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3271   +/-   ##
=======================================
  Coverage   99.02%   99.02%           
=======================================
  Files        1835     1837    +2     
  Lines       27028    27048   +20     
  Branches      158      158           
=======================================
+ Hits        26765    26785   +20     
  Misses        225      225           
  Partials       38       38           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MaxGhenis MaxGhenis merged commit 12bcccd into master Nov 15, 2023
6 checks passed
@MaxGhenis MaxGhenis deleted the PavelMakarchuk/issue3270 branch November 15, 2023 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate Ohio income tax parameter name deductions
2 participants