Remove taxcalc-related variable aliases

changelog_entry.yaml

@@ -0,0 +1,6 @@
+- bump: patch
+  changes:
+    fixed:
+    - Remove obsolete taxcalc-related alias variable names.
+    - Rename `earned_income_tax_credit` to `eitc` to be more consistent with variable names for other federal credits.
+

policyengine_us/parameters/gov/states/mo/tax/income/deductions/federal_income_tax/ignored_credits.yaml

@@ -1,7 +1,7 @@
 description: Ignored credits in MO federal income tax deduction calculations.
 values:
   2018-01-01:
-    - earned_income_tax_credit
+    - eitc
     - recovery_rebate_credit
 metadata:
   unit: variable

policyengine_us/parameters/gov/states/ok/tax/income/credits/gross_income_sources.yaml

@@ -23,7 +23,7 @@ values:
     - ssi
     - state_supplement  # state SSI supplement
     - general_assistance
-    - earned_income_tax_credit
+    - eitc
 
 metadata:
   label: Oklahoma sales tax credit gross income sources

policyengine_us/reforms/winship.py

@@ -28,7 +28,7 @@ def formula(tax_unit, period, parameters):
             limitation = max_(0, maximum - reduction)
             return min_(phased_in, limitation)
 
-    class earned_income_tax_credit(Variable):
+    class eitc(Variable):
         value_type = float
         entity = TaxUnit
         definition_period = YEAR
@@ -75,7 +75,7 @@ def formula(tax_unit, period, parameters):
     class winship_eitc_reform(Reform):
         def apply(self):
             self.add_variable(original_eitc)
-            self.update_variable(earned_income_tax_credit)
+            self.update_variable(eitc)
 
     return winship_eitc_reform
 

policyengine_us/tests/policy/baseline/gov/irs/outputs/c07230.yaml → policyengine_us/tests/policy/baseline/gov/irs/credits/education/education_tax_credits.yaml

@@ -1,12 +1,12 @@
 - name: Defaults to zero
   period: 2020
   output:
-    c07230: 0
+    education_tax_credits: 0
 
 - name: Sums non-refundable American Opportunity Credit and Lifetime Learning Credit
   period: 2020
   input:
     non_refundable_american_opportunity_credit: 1
     lifetime_learning_credit: 1
   output:
-    c07230: 2
+    education_tax_credits: 2

policyengine_us/tests/policy/baseline/gov/local/ny/nyc/tax/income/credits/nyc_eitc.yaml

@@ -4,7 +4,7 @@
   input:
     state_code: NY
     in_nyc: true
-    earned_income_tax_credit: 100
+    eitc: 100
     ny_agi: 18_000
   output:
     # NYC EIC rate worksheet
@@ -39,7 +39,7 @@
   input:
     state_code: NY
     in_nyc: true
-    earned_income_tax_credit: 100
+    eitc: 100
     ny_agi: 21_000
   output:
     # NYC EIC rate worksheet

policyengine_us/tests/policy/baseline/gov/states/ca/tax/income/credits/earned_income/ca_eitc.yaml

@@ -46,7 +46,7 @@
         state_code: CA
   output:  # expected results from patched TAXSIM35 2023-02-22 version
     # expected US results:
-    earned_income_tax_credit: 0  # too much investment income to be eligible
+    eitc: 0  # too much investment income to be eligible
     income_tax: -9648
     # expected CA results:
     ca_income_tax_before_credits: 164.14  # this is a PolicyEngineUS output

policyengine_us/tests/policy/baseline/gov/states/co/tax/income/credits/eitc/co_eitc.yaml

@@ -1,31 +1,31 @@
 - name: co_eitc unit test 1
   period: 2021
   input:
-    earned_income_tax_credit: 100
+    eitc: 100
     state_code: CO
   output:
     co_eitc: 10
 
 - name: co_eitc unit test 2
   period: 2022
   input:
-    earned_income_tax_credit: 100
+    eitc: 100
     state_code: CO
   output:
     co_eitc: 20
 
 - name: co_eitc unit test 3
   period: 2023
   input:
-    earned_income_tax_credit: 100
+    eitc: 100
     state_code: CO
   output:
     co_eitc: 25
 
 - name: co_eitc unit test 4
   period: 2023
   input:
-    earned_income_tax_credit: 0
+    eitc: 0
     state_code: CO
   output:
     co_eitc: 0

policyengine_us/tests/policy/baseline/gov/states/ct/tax/income/credits/eitc/ct_eitc.yaml

@@ -2,14 +2,14 @@
   period: 2022
   input:
     state_code: CT
-    earned_income_tax_credit: 0
+    eitc: 0
   output:
     ct_eitc: 0
 
 - name: CT EITC, some matched credit and regular filing
   period: 2022
   input:
     state_code: CT
-    earned_income_tax_credit: 2_000
+    eitc: 2_000
   output:
     ct_eitc: 610

policyengine_us/tests/policy/baseline/gov/states/dc/tax/income/dc_eitc_with_qualifying_child.yaml

@@ -2,14 +2,14 @@
   period: 2023
   input:
     state_code: DC
-    earned_income_tax_credit: 0
+    eitc: 0
   output:
     dc_eitc_with_qualifying_child: 0
 
 - name: 70% match
   period: 2023
   input:
     state_code: DC
-    earned_income_tax_credit: 100
+    eitc: 100
   output:
     dc_eitc_with_qualifying_child: 70

policyengine_us/tests/policy/baseline/gov/states/de/tax/income/credits/eitc/de_non_refundable_eitc_if_claimed.yaml

@@ -2,14 +2,14 @@
   period: 2022
   input:
     state_code: DE
-    earned_income_tax_credit: 0
+    eitc: 0
   output:
     de_non_refundable_eitc_if_claimed: 0
 
 - name: Non refundable rate of 20%
   period: 2022
   input:
     state_code: DE
-    earned_income_tax_credit: 1_000
+    eitc: 1_000
   output:
     de_non_refundable_eitc_if_claimed: 200

policyengine_us/tests/policy/baseline/gov/states/de/tax/income/credits/eitc/de_refundable_eitc_if_claimed.yaml

@@ -2,14 +2,14 @@
   period: 2022
   input:
     state_code: DE
-    earned_income_tax_credit: 1_000
+    eitc: 1_000
   output:
     de_refundable_eitc_if_claimed: 45
 
 - name: No EITC
   period: 2022
   input:
     state_code: DE
-    earned_income_tax_credit: 0
+    eitc: 0
   output:
     de_refundable_eitc_if_claimed: 0

policyengine_us/tests/policy/baseline/gov/states/hi/tax/income/credits/hi_eitc.yaml

@@ -1,15 +1,15 @@
 - name: No EITC
   period: 2022
   input:
-    earned_income_tax_credit: 0
+    eitc: 0
     state_code: HI
   output:
     hi_eitc: 0
 
 - name: 20% match of fed EITC
   period: 2022
   input:
-    earned_income_tax_credit: 1_000
+    eitc: 1_000
     state_code: HI
   output:
     hi_eitc: 200

policyengine_us/tests/policy/baseline/gov/states/ia/tax/income/ia_eitc.yaml

@@ -1,7 +1,7 @@
 - name: IA eitc unit test 1
   period: 2021
   input:
-    earned_income_tax_credit: 1_000
+    eitc: 1_000
     state_code: IA
   output:
     ia_eitc: 150

policyengine_us/tests/policy/baseline/gov/states/il/tax/income/credits/il_eitc.yaml

@@ -2,7 +2,7 @@
   period: 2021
   absolute_error_margin: 0.0001
   input:
-    earned_income_tax_credit: 1_000
+    eitc: 1_000
     state_code: IL
   output:
     il_eitc: 1_000 * 0.18

policyengine_us/tests/policy/baseline/gov/states/in/tax/income/in_eitc.yaml

@@ -4,7 +4,7 @@
   input:
     gov.states.in.tax.income.credits.earned_income.decoupled: false
     state_code: IN
-    earned_income_tax_credit: 100
+    eitc: 100
     in_eitc_eligible: true
   output:
     in_eitc: 10

policyengine_us/tests/policy/baseline/gov/states/in/tax/income/in_eitc_eligible.yaml

@@ -3,7 +3,7 @@
   input:
     gov.states.in.tax.income.credits.earned_income.decoupled: true
     state_code: IN
-    earned_income_tax_credit: 999
+    eitc: 999
     filing_status: SINGLE
     eitc_child_count: 0
     age_head: 64
@@ -16,7 +16,7 @@
   input:
     gov.states.in.tax.income.credits.earned_income.decoupled: true
     state_code: IN
-    earned_income_tax_credit: 999
+    eitc: 999
     filing_status: SEPARATE
     eitc_child_count: 0
     age_head: 64
@@ -29,7 +29,7 @@
   input:
     gov.states.in.tax.income.credits.earned_income.decoupled: true
     state_code: IN
-    earned_income_tax_credit: 999
+    eitc: 999
     filing_status: SINGLE
     eitc_child_count: 0
     age_head: 65
@@ -42,7 +42,7 @@
   input:
     gov.states.in.tax.income.credits.earned_income.decoupled: true
     state_code: IN
-    earned_income_tax_credit: 999
+    eitc: 999
     filing_status: SINGLE
     eitc_child_count: 0
     age_head: 64
@@ -55,7 +55,7 @@
   input:
     gov.states.in.tax.income.credits.earned_income.decoupled: true
     state_code: IN
-    earned_income_tax_credit: 0
+    eitc: 0
     filing_status: SINGLE
     eitc_child_count: 0
     age_head: 64
@@ -68,7 +68,7 @@
   input:
     gov.states.in.tax.income.credits.earned_income.decoupled: false
     state_code: IN
-    earned_income_tax_credit: 999
+    eitc: 999
     filing_status: SEPARATE
     eitc_child_count: 0
     age_head: 65

policyengine_us/tests/policy/baseline/gov/states/ks/tax/income/ks_total_eitc.yaml

@@ -1,7 +1,7 @@
 - name: KS total eitc unit test
   period: 2021
   input:
-    earned_income_tax_credit: 1_000
+    eitc: 1_000
     state_code: KS
   output:
     ks_total_eitc: 0.17 * 1_000

policyengine_us/tests/policy/baseline/gov/states/la/tax/income/credits/la_eitc.yaml

@@ -1,15 +1,15 @@
 - name: 5% of federal EITC after 2019.
   period: 2023
   input:
-    earned_income_tax_credit: 100
+    eitc: 100
     state_code: LA
   output:
     la_eitc: 5
 
 - name: If no federal EITC, no Louisiana EITC.
   period: 2023
   input:
-    earned_income_tax_credit: 0
+    eitc: 0
     state_code: LA
   output:
     la_eitc: 0

policyengine_us/tests/policy/baseline/gov/states/ma/tax/income/credits/ma_eitc.yaml

@@ -3,7 +3,7 @@
   absolute_error_margin: 1
   input:
     state_code: MA
-    earned_income_tax_credit: 0
+    eitc: 0
   output:
     ma_eitc: 0
 
@@ -12,6 +12,6 @@
   absolute_error_margin: 1
   input:
     state_code: MA
-    earned_income_tax_credit: 100
+    eitc: 100
   output:
     ma_eitc: 30

policyengine_us/tests/policy/baseline/gov/states/me/tax/income/credits/me_eitc.yaml

@@ -10,7 +10,7 @@
     tax_units:
       tax_unit:
         members: [person1, person2]
-        earned_income_tax_credit: 0
+        eitc: 0
     households:
       household:
         members: [person1, person2]
@@ -30,7 +30,7 @@
     tax_units:
       tax_unit:
         members: [person1, person2]
-        earned_income_tax_credit: 500
+        eitc: 500
     households:
       household:
         members: [person1, person2]
@@ -50,7 +50,7 @@
     tax_units:
       tax_unit:
         members: [person1, person2]
-        earned_income_tax_credit: 500
+        eitc: 500
     households:
       household:
         members: [person1, person2]
@@ -70,7 +70,7 @@
     tax_units:
       tax_unit:
         members: [person1, person2]
-        earned_income_tax_credit: 500
+        eitc: 500
     households:
       household:
         members: [person1, person2]
@@ -92,7 +92,7 @@
     tax_units:
       tax_unit:
         members: [person1, person2, person3]
-        earned_income_tax_credit: 500
+        eitc: 500
     households:
       household:
         members: [person1, person2, person3]