Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish elimination of taxcalc-related variables #3226

Merged
merged 18 commits into from
Nov 3, 2023
Merged

Finish elimination of taxcalc-related variables #3226

merged 18 commits into from
Nov 3, 2023

Conversation

martinholmer
Copy link
Collaborator

@martinholmer martinholmer commented Nov 3, 2023

Fixes #3225.

🤖 Generated by Copilot at d707e5a

Summary

📝🆕🐛

This pull request makes several changes to the policyengine-us codebase, mainly related to renaming and reorganizing variables and parameters to improve clarity, consistency, and accuracy. It also adds a new parameter for the capital gains loss limit, fixes a unit error in another parameter, and updates the changelog file. The changes affect the Winship reform, the federal and state income taxes, and the child and dependent care credit.

We're the masters of the code, we change the names and paths
We fix the bugs and errors, we make the formulas last
We update the test cases, we check the parameters
We write the changelog, we are the reformers

Walkthrough

  • Add a new changelog entry for version 0.1.1 (link)
  • Add a new parameter file for the capital gains loss limit (link)
  • Fix the unit of the personal exemption phase-out step size parameter (link)

Copy link

codecov bot commented Nov 3, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2520ab6) 99.02% compared to head (d707e5a) 99.02%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3226      +/-   ##
==========================================
- Coverage   99.02%   99.02%   -0.01%     
==========================================
  Files        1798     1803       +5     
  Lines       26614    26608       -6     
  Branches      155      155              
==========================================
- Hits        26354    26348       -6     
  Misses        223      223              
  Partials       37       37              
Files Coverage Δ
...e_us/variables/gov/irs/credits/cdcc/head_earned.py 100.00% <100.00%> (ø)
...us/variables/gov/irs/credits/cdcc/spouse_earned.py 100.00% <100.00%> (ø)
...es/gov/irs/credits/earned_income/eitc_phased_in.py 100.00% <100.00%> (ø)
...es/gov/irs/credits/earned_income/eitc_reduction.py 100.00% <100.00%> (ø)
...s/earned_income/eitc_relevant_investment_income.py 100.00% <100.00%> (ø)
...e_us/variables/gov/irs/income/adjusted_earnings.py 100.00% <100.00%> (ø)
...ariables/gov/irs/income/filer_adjusted_earnings.py 100.00% <100.00%> (ø)
..._gross_income/irs_gross_income/has_qdiv_or_ltcg.py 100.00% <100.00%> (ø)
...irs_gross_income/loss_limited_net_capital_gains.py 100.00% <100.00%> (ø)
...ons/standard_deduction/basic_standard_deduction.py 100.00% <100.00%> (ø)
... and 32 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

changelog_entry.yaml Show resolved Hide resolved
Copy link

codecov bot commented Nov 3, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2520ab6) 99.02% compared to head (e483883) 99.02%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3226      +/-   ##
==========================================
- Coverage   99.02%   99.02%   -0.01%     
==========================================
  Files        1798     1803       +5     
  Lines       26614    26608       -6     
  Branches      155      155              
==========================================
- Hits        26354    26348       -6     
  Misses        223      223              
  Partials       37       37              
Files Coverage Δ
...e_us/variables/gov/irs/credits/cdcc/head_earned.py 100.00% <100.00%> (ø)
...us/variables/gov/irs/credits/cdcc/spouse_earned.py 100.00% <100.00%> (ø)
...es/gov/irs/credits/earned_income/eitc_phased_in.py 100.00% <100.00%> (ø)
...es/gov/irs/credits/earned_income/eitc_reduction.py 100.00% <100.00%> (ø)
...s/earned_income/eitc_relevant_investment_income.py 100.00% <100.00%> (ø)
...e_us/variables/gov/irs/income/adjusted_earnings.py 100.00% <100.00%> (ø)
...ariables/gov/irs/income/filer_adjusted_earnings.py 100.00% <100.00%> (ø)
..._gross_income/irs_gross_income/has_qdiv_or_ltcg.py 100.00% <100.00%> (ø)
...irs_gross_income/loss_limited_net_capital_gains.py 100.00% <100.00%> (ø)
...ons/standard_deduction/basic_standard_deduction.py 100.00% <100.00%> (ø)
... and 32 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MaxGhenis MaxGhenis merged commit 582af67 into PolicyEngine:master Nov 3, 2023
6 checks passed
@martinholmer martinholmer deleted the taxcalc-cleanup-5 branch November 3, 2023 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove last variables in the gov/irs/taxcalc/ directory
2 participants