-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Idaho Deduction for dependents 65 or older with developmental disabilities #3130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: jialyu0411 <[email protected]>
…ities Fixes PolicyEngine#2775 Co-authored-by: jialyu0411 <[email protected]>
...gine_us/parameters/gov/states/id/tax/income/deductions/aged_or_disabled/age_eligibility.yaml
Outdated
Show resolved
Hide resolved
...gine_us/parameters/gov/states/id/tax/income/deductions/aged_or_disabled/age_eligibility.yaml
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3130 +/- ##
=======================================
Coverage 99.12% 99.12%
=======================================
Files 2039 2046 +7
Lines 29624 29720 +96
Branches 163 163
=======================================
+ Hits 29364 29460 +96
Misses 223 223
Partials 37 37 ☔ View full report in Codecov by Sentry. |
...ngine_us/parameters/gov/states/id/tax/income/deductions/aged_or_disabled/max_deductions.yaml
Outdated
Show resolved
Hide resolved
...ne_us/tests/policy/baseline/gov/states/id/tax/income/credits/id_aged_or_disabled_credit.yaml
Outdated
Show resolved
Hide resolved
policyengine_us/parameters/gov/states/id/tax/income/credits/aged_or_disabled/amount.yaml
Outdated
Show resolved
Hide resolved
policyengine_us/variables/gov/states/id/tax/income/credits/id_aged_or_disabled_credit.py
Outdated
Show resolved
Hide resolved
...tests/policy/baseline/gov/states/id/tax/income/deductions/id_aged_or_disabled_deduction.yaml
Outdated
Show resolved
Hide resolved
...ngine_us/parameters/gov/states/id/tax/income/deductions/aged_or_disabled/max_deductions.yaml
Outdated
Show resolved
Hide resolved
...ngine_us/parameters/gov/states/id/tax/income/deductions/aged_or_disabled/max_deductions.yaml
Outdated
Show resolved
Hide resolved
...ngine_us/parameters/gov/states/id/tax/income/deductions/aged_or_disabled/max_deductions.yaml
Outdated
Show resolved
Hide resolved
...yengine_us/parameters/gov/states/id/tax/income/credits/aged_or_disabled/age_eligibility.yaml
Outdated
Show resolved
Hide resolved
...yengine_us/parameters/gov/states/id/tax/income/credits/aged_or_disabled/age_eligibility.yaml
Outdated
Show resolved
Hide resolved
..._us/variables/gov/states/id/tax/income/credits/id_aged_or_disabled_credit_eligible_person.py
Outdated
Show resolved
Hide resolved
…aged_or_disabled_credit_eligible_person.py
PavelMakarchuk
requested changes
Dec 1, 2023
...ables/gov/states/id/tax/income/subtractions/id_aged_or_disabled_deduction_eligible_person.py
Outdated
Show resolved
Hide resolved
...ables/gov/states/id/tax/income/subtractions/id_aged_or_disabled_deduction_eligible_person.py
Outdated
Show resolved
Hide resolved
...ables/gov/states/id/tax/income/subtractions/id_aged_or_disabled_deduction_eligible_person.py
Outdated
Show resolved
Hide resolved
...ables/gov/states/id/tax/income/subtractions/id_aged_or_disabled_deduction_eligible_person.py
Outdated
Show resolved
Hide resolved
...ables/gov/states/id/tax/income/subtractions/id_aged_or_disabled_deduction_eligible_person.py
Outdated
Show resolved
Hide resolved
..._us/variables/gov/states/id/tax/income/credits/id_aged_or_disabled_credit_eligible_person.py
Outdated
Show resolved
Hide resolved
..._us/variables/gov/states/id/tax/income/credits/id_aged_or_disabled_credit_eligible_person.py
Outdated
Show resolved
Hide resolved
..._us/variables/gov/states/id/tax/income/credits/id_aged_or_disabled_credit_eligible_person.py
Outdated
Show resolved
Hide resolved
policyengine_us/parameters/gov/states/id/tax/income/credits/aged_or_disabled/age_threshold.yaml
Outdated
Show resolved
Hide resolved
…elderly_homeowner_or_renter_credit/mt_elderly_homeowner_or_renter_credit_eligible.py
PavelMakarchuk
approved these changes
Dec 6, 2023
MaxGhenis
requested changes
Dec 15, 2023
policyengine_us/parameters/gov/states/id/tax/income/credits/refundable.yaml
Outdated
Show resolved
Hide resolved
policyengine_us/parameters/gov/states/id/tax/income/credits/aged_or_disabled/amount.yaml
Outdated
Show resolved
Hide resolved
...eters/gov/states/id/tax/income/subtractions/aged_or_disabled/support_fraction_threshold.yaml
Outdated
Show resolved
Hide resolved
...eters/gov/states/id/tax/income/subtractions/aged_or_disabled/support_fraction_threshold.yaml
Outdated
Show resolved
Hide resolved
policyengine_us/variables/gov/states/id/tax/income/id_receives_aged_or_disabled_credit.py
Show resolved
Hide resolved
...cyengine_us/variables/gov/states/id/tax/income/subtractions/id_aged_or_disabled_deduction.py
Outdated
Show resolved
Hide resolved
policyengine_us/variables/gov/states/id/tax/income/credits/id_aged_or_disabled_credit.py
Outdated
Show resolved
Hide resolved
policyengine_us/parameters/gov/states/id/tax/income/subtractions/subtractions.yaml
Show resolved
Hide resolved
policyengine_us/parameters/gov/states/id/tax/income/subtractions/aged_or_disabled/amount.yaml
Outdated
Show resolved
Hide resolved
MaxGhenis
requested changes
Dec 15, 2023
policyengine_us/variables/gov/states/id/tax/income/id_receives_aged_or_disabled_credit.py
Outdated
Show resolved
Hide resolved
MaxGhenis
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2775
🤖 Generated by Copilot at c7593a7
Summary
📝📊🧮
This pull request adds a new feature to the policy engine for the US: the Idaho aged and disabled deduction. It creates parameter files, a variable file, and a test file for the deduction, and updates the changelog entry accordingly.
Walkthrough
id_aged_or_disabled_deduction
, with value type, entity, label, unit, definition period, state code, and formula (link)id_aged_or_disabled_deduction
, with five test cases covering different scenarios (link)