-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Montana Interest Exemptions #3098
Merged
MaxGhenis
merged 22 commits into
PolicyEngine:master
from
DianaShi5083:DianaShi5083/issue3058
Nov 15, 2023
Merged
Added Montana Interest Exemptions #3098
MaxGhenis
merged 22 commits into
PolicyEngine:master
from
DianaShi5083:DianaShi5083/issue3058
Nov 15, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
policyengine_us/parameters/gov/states/mt/tax/income/exemptions/amount.yaml
Outdated
Show resolved
Hide resolved
policyengine_us/parameters/gov/states/mt/tax/income/exemptions/interest/age.yaml
Outdated
Show resolved
Hide resolved
policyengine_us/parameters/gov/states/mt/tax/income/exemptions/amount.yaml
Show resolved
Hide resolved
policyengine_us/parameters/gov/states/mt/tax/income/exemptions/interest/amount.yaml
Outdated
Show resolved
Hide resolved
policyengine_us/variables/gov/states/mt/tax/income/exemptions/mt_interest.py
Outdated
Show resolved
Hide resolved
MaxGhenis
requested changes
Sep 28, 2023
policyengine_us/variables/gov/states/mt/tax/income/exemptions/mt_interest.py
Outdated
Show resolved
Hide resolved
policyengine_us/variables/gov/states/mt/tax/income/exemptions/mt_interest.py
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3098 +/- ##
=======================================
Coverage 99.02% 99.02%
=======================================
Files 1828 1831 +3
Lines 26941 26981 +40
Branches 158 158
=======================================
+ Hits 26678 26718 +40
Misses 225 225
Partials 38 38 ☔ View full report in Codecov by Sentry. |
MaxGhenis
requested changes
Oct 4, 2023
policyengine_us/variables/gov/states/mt/tax/income/exemptions/mt_interest_exemptions.py
Outdated
Show resolved
Hide resolved
policyengine_us/variables/gov/states/mt/tax/income/exemptions/mt_interest_exemptions.py
Outdated
Show resolved
Hide resolved
policyengine_us/variables/gov/states/mt/tax/income/exemptions/mt_interest_exemptions.py
Outdated
Show resolved
Hide resolved
policyengine_us/parameters/gov/states/mt/tax/income/exemptions/interest/age.yaml
Outdated
Show resolved
Hide resolved
policyengine_us/parameters/gov/states/mt/tax/income/exemptions/interest/age.yaml
Outdated
Show resolved
Hide resolved
policyengine_us/parameters/gov/states/mt/tax/income/exemptions/interest/amount.yaml
Outdated
Show resolved
Hide resolved
policyengine_us/parameters/gov/states/mt/tax/income/exemptions/interest/amount.yaml
Outdated
Show resolved
Hide resolved
policyengine_us/parameters/gov/states/mt/tax/income/exemptions/interest/amount.yaml
Outdated
Show resolved
Hide resolved
policyengine_us/variables/gov/states/mt/tax/income/exemptions/mt_interest_exemptions.py
Outdated
Show resolved
Hide resolved
policyengine_us/variables/gov/states/mt/tax/income/exemptions/mt_interest_exemptions.py
Outdated
Show resolved
Hide resolved
policyengine_us/parameters/gov/states/mt/tax/income/exemptions/interest/cap.yaml
Show resolved
Hide resolved
MaxGhenis
requested changes
Oct 12, 2023
policyengine_us/variables/gov/states/mt/tax/income/exemptions/mt_interest_exemptions.py
Outdated
Show resolved
Hide resolved
policyengine_us/variables/gov/states/mt/tax/income/exemptions/mt_interest_exemptions.py
Outdated
Show resolved
Hide resolved
policyengine_us/variables/gov/states/mt/tax/income/exemptions/mt_interest_exemptions.py
Outdated
Show resolved
Hide resolved
policyengine_us/variables/gov/states/mt/tax/income/exemptions/mt_interest_exemptions.py
Outdated
Show resolved
Hide resolved
policyengine_us/variables/gov/states/mt/tax/income/exemptions/mt_interest_exemptions.py
Outdated
Show resolved
Hide resolved
policyengine_us/variables/gov/states/mt/tax/income/exemptions/mt_interest_exemption.py
Show resolved
Hide resolved
policyengine_us/variables/gov/states/mt/tax/income/exemptions/mt_interest_exemption_eligible.py
Show resolved
Hide resolved
policyengine_us/variables/gov/states/mt/tax/income/exemptions/mt_interest_exemption_eligible.py
Show resolved
Hide resolved
policyengine_us/variables/gov/states/mt/tax/income/exemptions/mt_interest_exemption_eligible.py
Outdated
Show resolved
Hide resolved
policyengine_us/variables/gov/states/mt/tax/income/exemptions/mt_interest_exemption.py
Outdated
Show resolved
Hide resolved
policyengine_us/variables/gov/states/mt/tax/income/exemptions/mt_interest_exemption.py
Show resolved
Hide resolved
policyengine_us/variables/gov/states/mt/tax/income/exemptions/mt_interest_exemption_eligible.py
Show resolved
Hide resolved
policyengine_us/parameters/gov/states/mt/tax/income/exemptions/interest/age.yaml
Outdated
Show resolved
Hide resolved
policyengine_us/parameters/gov/states/mt/tax/income/exemptions/interest/age.yaml
Outdated
Show resolved
Hide resolved
policyengine_us/parameters/gov/states/mt/tax/income/exemptions/interest/cap.yaml
Outdated
Show resolved
Hide resolved
policyengine_us/parameters/gov/states/mt/tax/income/exemptions/interest/cap.yaml
Outdated
Show resolved
Hide resolved
policyengine_us/variables/gov/states/mt/tax/income/exemptions/mt_interest_exemption.py
Outdated
Show resolved
Hide resolved
policyengine_us/variables/gov/states/mt/tax/income/exemptions/mt_interest_exemption.py
Outdated
Show resolved
Hide resolved
policyengine_us/variables/gov/states/mt/tax/income/exemptions/mt_interest_exemption.py
Outdated
Show resolved
Hide resolved
policyengine_us/parameters/gov/states/mt/tax/income/exemptions/interest/age_threshold.yaml
Outdated
Show resolved
Hide resolved
policyengine_us/parameters/gov/states/mt/tax/income/exemptions/interest/cap.yaml
Outdated
Show resolved
Hide resolved
policyengine_us/parameters/gov/states/mt/tax/income/exemptions/interest/cap.yaml
Outdated
Show resolved
Hide resolved
…/interest/cap.yaml
…mt_interest_exemption_eligible.py
PavelMakarchuk
approved these changes
Nov 14, 2023
MaxGhenis
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3058
🤖 Generated by Copilot at 4d6744a
Summary
✨📄📝
This pull request adds support for Montana interest exemptions in the policy engine. It introduces new parameters, variables, and tests for the feature, and updates the changelog accordingly. The files affected are
changelog_entry.yaml
,age.yaml
,amount.yaml
,mt_interest_exemption.yaml
, andmt_interest.py
.Walkthrough
mt_exemptions
that calculates the amount of exemptions a tax unit can claim based on their dividend income, filing status, and age (link)age.yaml
) and the amount (amount.yaml
) of Montana interest exemptions, with descriptions, metadata, references, and values (link, link)mt_interest_exemption.yaml
) that checks the output ofmt_exemptions
against the expected values for three test cases with different filing statuses and ages (link)