Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Ohio Joint Filing Credit #3086

Merged
merged 27 commits into from
Dec 24, 2023
Merged

Add Ohio Joint Filing Credit #3086

merged 27 commits into from
Dec 24, 2023

Conversation

mylittlebecca
Copy link
Collaborator

Fix #3057

@codecov
Copy link

codecov bot commented Sep 26, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f58f35b) 98.99% compared to head (a082a4e) 98.99%.
Report is 2 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff            @@
##           master    #3086    +/-   ##
========================================
  Coverage   98.99%   98.99%            
========================================
  Files        2076     2085     +9     
  Lines       30224    30343   +119     
  Branches      165      165            
========================================
+ Hits        29920    30039   +119     
  Misses        268      268            
  Partials       36       36

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

PavelMakarchuk
PavelMakarchuk reviewed Nov 4, 2023
View reviewed changes
changelog_entry.yaml Outdated Show resolved Hide resolved
@PavelMakarchuk PavelMakarchuk self-requested a review December 14, 2023 18:14
@PavelMakarchuk
Copy link
Collaborator

failed checks relate to labor supply responses.py

MaxGhenis
MaxGhenis requested changes Dec 24, 2023
View reviewed changes
..._us/variables/gov/states/oh/tax/income/credits/joint_filing_credit/oh_joint_filing_credit.py Outdated Show resolved Hide resolved
..._us/variables/gov/states/oh/tax/income/credits/joint_filing_credit/oh_joint_filing_credit.py Outdated Show resolved Hide resolved
..._us/variables/gov/states/oh/tax/income/credits/joint_filing_credit/oh_joint_filing_credit.py Show resolved Hide resolved
..._us/variables/gov/states/oh/tax/income/credits/joint_filing_credit/oh_joint_filing_credit.py Outdated Show resolved Hide resolved
..._us/variables/gov/states/oh/tax/income/credits/joint_filing_credit/oh_joint_filing_credit.py Outdated Show resolved Hide resolved
...bles/gov/states/oh/tax/income/credits/joint_filing_credit/oh_joint_filing_credit_eligible.py Outdated Show resolved Hide resolved
policyengine_us/parameters/gov/states/oh/tax/income/credits/joint_filing/rate.yaml Outdated Show resolved Hide resolved
...s/parameters/gov/states/oh/tax/income/credits/joint_filing/other_non_refundable_credits.yaml Outdated Show resolved Hide resolved
policyengine_us/parameters/gov/states/oh/tax/income/credits/joint_filing/income_threshold.yaml Outdated Show resolved Hide resolved
@PavelMakarchuk PavelMakarchuk requested review from MaxGhenis and removed request for MaxGhenis December 24, 2023 23:14
@MaxGhenis MaxGhenis merged commit 448b179 into PolicyEngine:master Dec 24, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PavelMakarchuk PavelMakarchuk PavelMakarchuk approved these changes

@MaxGhenis MaxGhenis MaxGhenis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ohio Joint Filing Credit
3 participants
@mylittlebecca @PavelMakarchuk @MaxGhenis